Add more testcase assertions to cover all cases

Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
phpmyadmin · Nov 21, 2016 · 29c6cd3 · 29c6cd3
1 parent 592caad
commit 29c6cd3
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/libraries/server_privileges.lib.php b/libraries/server_privileges.lib.php
@@ -1547,7 +1547,7 @@ function PMA_getHtmlForAuthPluginsDropdown(
         }
     } else {
         $active_auth_plugins = array(
-            'mysql_native_password' => __('Native MySQL Authentication')
+            'mysql_native_password' => __('Native MySQL authentication')
         );
     }
 

diff --git a/test/libraries/PMA_server_privileges_test.php b/test/libraries/PMA_server_privileges_test.php
@@ -2366,9 +2366,37 @@ function testPMAGetHtmlForAuthPluginsDropdown()
             $actualHtml
         );
 
+        /* Assertion 3 */
+        $actualHtml = PMA_getHtmlForAuthPluginsDropdown(
+            'mysql_native_password',
+            'new',
+            'old'
+        );
+        $this->assertEquals(
+            '<select name="authentication_plugin" '
+            . 'id="select_authentication_plugin"><option '
+            . 'value="mysql_native_password" selected="selected">'
+            . 'Native MySQL authentication</option></select>',
+            $actualHtml
+        );
 
-        $GLOBALS['dbi'] = $oldDbi;
 
+        /* Assertion 4 */
+        $actualHtml = PMA_getHtmlForAuthPluginsDropdown(
+            'mysql_native_password',
+            'change_pw',
+            'old'
+        );
+        $this->assertEquals(
+            '<select name="authentication_plugin" '
+            . 'id="select_authentication_plugin_cp"><option '
+            . 'value="mysql_native_password" selected="selected">'
+            . 'Native MySQL authentication</option></select>',
+            $actualHtml
+        );
+
+        // Restore old DBI
+        $GLOBALS['dbi'] = $oldDbi;
     }
 
     /**