#14260 Fixed configuration for DefaultLang and Lang

Closes: #14260 Signed-off-by: William Desportes <williamdes@wdes.fr>
phpmyadmin · May 6, 2018 · 2f84b40 · 2f84b40
1 parent bb9fc5d
commit 2f84b40
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/libraries/classes/LanguageManager.php b/libraries/classes/LanguageManager.php
@@ -822,8 +822,8 @@ public function getCurrentLanguage()
     public function selectLanguage()
     {
         // check forced language
-        if (! empty($GLOBALS['cfg']['Lang'])) {
-            $lang = $this->getLanguage($GLOBALS['cfg']['Lang']);
+        if (! empty($GLOBALS['PMA_Config']->get('Lang'))) {
+            $lang = $this->getLanguage($GLOBALS['PMA_Config']->get('Lang'));
             if ($lang !== false) {
                 return $lang;
             }
@@ -883,8 +883,8 @@ public function selectLanguage()
         }
 
         // Didn't catch any valid lang : we use the default settings
-        if (isset($langs[$GLOBALS['cfg']['DefaultLang']])) {
-            return $langs[$GLOBALS['cfg']['DefaultLang']];
+        if (isset($langs[$GLOBALS['PMA_Config']->get('DefaultLang')])) {
+            return $langs[$GLOBALS['PMA_Config']->get('DefaultLang')];
         }
 
         // Fallback to English

diff --git a/test/classes/LanguageTest.php b/test/classes/LanguageTest.php
@@ -158,25 +158,25 @@ public function testGet()
      */
     public function testSelect($lang, $post, $get, $cookie, $accept, $agent, $default, $expect)
     {
-        $GLOBALS['cfg']['Lang'] = $lang;
+        $GLOBALS['PMA_Config']->set('Lang', $lang);
         $_POST['lang'] = $post;
         $_GET['lang'] = $get;
         $_COOKIE['pma_lang'] = $cookie;
         $_SERVER['HTTP_ACCEPT_LANGUAGE'] = $accept;
         $_SERVER['HTTP_USER_AGENT'] = $agent;
-        $GLOBALS['cfg']['DefaultLang'] = $default;
+        $GLOBALS['PMA_Config']->set('DefaultLang', $default);
 
         $lang = $this->manager->selectLanguage();
 
         $this->assertEquals($expect, $lang->getEnglishName());
 
-        $GLOBALS['cfg']['Lang'] = '';
+        $GLOBALS['PMA_Config']->set('Lang', '');
         $_POST['lang'] = '';
         $_GET['lang'] = '';
         $_COOKIE['pma_lang'] = '';
         $_SERVER['HTTP_ACCEPT_LANGUAGE'] = '';
         $_SERVER['HTTP_USER_AGENT'] = '';
-        $GLOBALS['cfg']['DefaultLang'] = 'en';
+        $GLOBALS['PMA_Config']->set('DefaultLang', 'en');
     }
 
     /**
@@ -191,6 +191,7 @@ public function selectDataProvider()
             array('', 'cs', '', '' ,'' ,'', '', 'Czech'),
             array('', 'cs', 'en', '' ,'' ,'', '', 'Czech'),
             array('', '', 'cs', '' ,'' ,'', '', 'Czech'),
+            array('', '', '', 'cs' ,'' ,'', '', 'Czech'),
             array('', '', '', '' ,'cs,en-US;q=0.7,en;q=0.3' ,'', '', 'Czech'),
             array(
                 '', '', '', '', '',