Merge pull request #17439 from Jir4/fix-tabindex

Enable tabindex recompute on preview button while insert new rows
phpmyadmin · Mar 16, 2022 · 39fac83 · 39fac83
2 parents 0c7cab4 + 57ad99b
commit 39fac83
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/libraries/classes/InsertEdit.php b/libraries/classes/InsertEdit.php
@@ -1976,7 +1976,8 @@ private function getSubmitAndResetButtonForActionsPanel($tabindex, $tabindex_for
             )
             . '</td>'
             . '<td colspan="3" class="right vmiddle">'
-            . '<input type="button" class="btn btn-secondary preview_sql" value="' . __('Preview SQL') . '"'
+            . '<input type="button" class="btn btn-secondary preview_sql control_at_footer"'
+            . ' value="' . __('Preview SQL') . '"'
             . ' tabindex="' . ($tabindex + $tabindex_for_value + 6) . '">'
             . '<input type="reset" class="btn btn-secondary control_at_footer" value="' . __('Reset') . '"'
             . ' tabindex="' . ($tabindex + $tabindex_for_value + 7) . '">'

diff --git a/test/classes/InsertEditTest.php b/test/classes/InsertEditTest.php
@@ -2484,7 +2484,7 @@ public function testGetSubmitAndResetButtonForActionsPanel(): void
         );
 
         $this->assertStringContainsString(
-            '<input type="button" class="btn btn-secondary preview_sql" value="Preview SQL" '
+            '<input type="button" class="btn btn-secondary preview_sql control_at_footer" value="Preview SQL" '
             . 'tabindex="7">',
             $result
         );