New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tabindex recompute on preview button while insert new rows #17439
Conversation
Signed-off-by: Yohann Dupont <yd@2dcom.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix @Jir4
Signed-off-by: Yohann Dupont <yd@2dcom.fr>
Codecov Report
@@ Coverage Diff @@
## QA_5_1 #17439 +/- ##
============================================
+ Coverage 57.77% 57.88% +0.10%
- Complexity 15327 15411 +84
============================================
Files 471 473 +2
Lines 62126 62158 +32
============================================
+ Hits 35895 35978 +83
+ Misses 26231 26180 -51
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Yohann Dupont <yd@2dcom.fr>
Is something missing @williamdes ? |
Merged, thanks for your contribution! |
Description
Allow to recompute the tabindex on the preview SQL button on the insert page.
Fixes #17111
Before submitting pull request, please review the following checklist:
Signed-off-by
line as described in our DCO. This ensures that the work you're submitting is your own creation.