Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tabindex recompute on preview button while insert new rows #17439

Merged
merged 3 commits into from Mar 16, 2022

Conversation

Jir4
Copy link
Contributor

@Jir4 Jir4 commented Mar 9, 2022

Description

Allow to recompute the tabindex on the preview SQL button on the insert page.

Fixes #17111

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Yohann Dupont <yd@2dcom.fr>
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix @Jir4

Signed-off-by: Yohann Dupont <yd@2dcom.fr>
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #17439 (57ad99b) into QA_5_1 (6387eaa) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             QA_5_1   #17439      +/-   ##
============================================
+ Coverage     57.77%   57.88%   +0.10%     
- Complexity    15327    15411      +84     
============================================
  Files           471      473       +2     
  Lines         62126    62158      +32     
============================================
+ Hits          35895    35978      +83     
+ Misses        26231    26180      -51     
Flag Coverage Δ
arch-7-amd64 58.63% <ø> (-2.50%) ⬇️
arch-7-arm32v6 58.51% <ø> (-2.50%) ⬇️
arch-7-arm32v7 58.51% <ø> (-2.50%) ⬇️
arch-7-arm64v8 58.63% <ø> (-2.50%) ⬇️
arch-7-i386 58.51% <ø> (-2.50%) ⬇️
arch-7-ppc64le 58.63% <ø> (-2.50%) ⬇️
arch-7-s390x 58.48% <ø> (-2.51%) ⬇️
dbase-extension 57.62% <100.00%> (+0.16%) ⬆️
recode-extension 57.58% <100.00%> (+0.16%) ⬆️
unit-7.1-ubuntu-latest 57.58% <100.00%> (+0.16%) ⬆️
unit-7.2-ubuntu-latest 57.75% <100.00%> (+0.16%) ⬆️
unit-7.3-ubuntu-latest 58.55% <ø> (-2.60%) ⬇️
unit-7.4-ubuntu-latest 58.55% <ø> (-2.60%) ⬇️
unit-8.0-ubuntu-latest 58.62% <ø> (-2.59%) ⬇️
unit-8.1-ubuntu-latest 58.57% <ø> (?)
unit-nightly-ubuntu-latest 58.58% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libraries/classes/InsertEdit.php 87.96% <100.00%> (+0.26%) ⬆️
libraries/classes/Gis/GisPoint.php 82.16% <0.00%> (-8.29%) ⬇️
libraries/classes/Url.php 87.91% <0.00%> (-3.40%) ⬇️
libraries/classes/ErrorHandler.php 63.58% <0.00%> (-2.37%) ⬇️
libraries/classes/Setup/FormProcessing.php 79.31% <0.00%> (-2.18%) ⬇️
libraries/classes/Gis/GisMultiPoint.php 87.83% <0.00%> (-1.59%) ⬇️
...es/classes/Controllers/Table/ReplaceController.php 59.17% <0.00%> (-1.50%) ⬇️
libraries/classes/CreateAddField.php 42.55% <0.00%> (-1.44%) ⬇️
...asses/Controllers/Database/StructureController.php 37.87% <0.00%> (-1.03%) ⬇️
libraries/classes/Controllers/SqlController.php 47.22% <0.00%> (-0.87%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6387eaa...57ad99b. Read the comment docs.

Signed-off-by: Yohann Dupont <yd@2dcom.fr>
@williamdes williamdes added this to the 5.1.4 milestone Mar 10, 2022
@Jir4
Copy link
Contributor Author

Jir4 commented Mar 16, 2022

Is something missing @williamdes ?

@MauricioFauth MauricioFauth merged commit 39fac83 into phpmyadmin:QA_5_1 Mar 16, 2022
@MauricioFauth
Copy link
Member

Merged, thanks for your contribution!

@MauricioFauth MauricioFauth self-assigned this Mar 16, 2022
@Jir4 Jir4 deleted the fix-tabindex branch June 22, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants