Fix #16942 - Table Import with CSV using LOAD DATA LOCAL causes error…

… "LOAD DATA LOCAL INFILE is forbidden"

Signed-off-by: William Desportes <williamdes@wdes.fr>

libraries/classes/Controllers/ImportController.php

@@ -22,7 +22,6 @@
 use PhpMyAdmin\Url;
 use PhpMyAdmin\Util;
 use Throwable;
-use function define;
 use function htmlspecialchars;
 use function in_array;
 use function ini_get;
@@ -88,11 +87,6 @@ public function index(): void
         $local_import_file = $_POST['local_import_file'] ?? null;
         $show_as_php = $_POST['show_as_php'] ?? null;
 
-        /* Enable LOAD DATA LOCAL INFILE for LDI plugin */
-        if ($format === 'ldi') {
-            define('PMA_ENABLE_LDI', 1);
-        }
-
         // If there is a request to 'Simulate DML'.
         if (isset($_POST['simulate_dml'])) {
             $this->import->handleSimulateDmlRequest();

libraries/common.inc.php

@@ -262,6 +262,14 @@
         $auth_plugin = Plugins::getAuthPlugin();
         $auth_plugin->authenticate();
 
+        /* Enable LOAD DATA LOCAL INFILE for LDI plugin */
+        if ($route === '/import' && ($_POST['format'] ?? '') === 'ldi') {
+            // Switch this before the DB connection is done
+            // phpcs:disable PSR1.Files.SideEffects
+            define('PMA_ENABLE_LDI', 1);
+            // phpcs:enable
+        }
+
         Core::connectToDatabaseServer($dbi, $auth_plugin);
 
         $auth_plugin->rememberCredentials();