Merge pull request #14846 from Tithugues/feature/replace-if-return-by…

…-return Replace if+return by return
phpmyadmin · Jan 12, 2019 · 8c8d570 · 8c8d570
2 parents 65d2693 + 5b19bb6
commit 8c8d570
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 16 deletions.
diff --git a/libraries/classes/Export.php b/libraries/classes/Export.php
@@ -60,16 +60,11 @@ public function gzencodeNeeded(): bool
         $chromeAndGreaterThan43 = PMA_USR_BROWSER_AGENT == 'CHROME'
             && PMA_USR_BROWSER_VER >= 43; // see bug #4942
 
-        if (function_exists('gzencode')
+        return function_exists('gzencode')
             && ((! ini_get('zlib.output_compression')
-            && ! $this->isGzHandlerEnabled())
-            || $GLOBALS['save_on_server']
-            || $chromeAndGreaterThan43)
-        ) {
-            return true;
-        }
-
-        return false;
+                    && ! $this->isGzHandlerEnabled())
+                || $GLOBALS['save_on_server']
+                || $chromeAndGreaterThan43);
     }
 
     /**

diff --git a/libraries/classes/Relation.php b/libraries/classes/Relation.php
@@ -2180,7 +2180,7 @@ public function getRelationsAndStatus($condition, $db, $table)
      */
     public function arePmadbTablesDefined()
     {
-        if (empty($GLOBALS['cfg']['Server']['bookmarktable'])
+        return ! (empty($GLOBALS['cfg']['Server']['bookmarktable'])
             || empty($GLOBALS['cfg']['Server']['relation'])
             || empty($GLOBALS['cfg']['Server']['table_info'])
             || empty($GLOBALS['cfg']['Server']['table_coords'])
@@ -2198,12 +2198,7 @@ public function arePmadbTablesDefined()
             || empty($GLOBALS['cfg']['Server']['savedsearches'])
             || empty($GLOBALS['cfg']['Server']['central_columns'])
             || empty($GLOBALS['cfg']['Server']['designer_settings'])
-            || empty($GLOBALS['cfg']['Server']['export_templates'])
-        ) {
-            return false;
-        }
-
-        return true;
+            || empty($GLOBALS['cfg']['Server']['export_templates']));
     }
 
     /**