Skip to content

Commit

Permalink
Fix saving user preferences to configuration storage
Browse files Browse the repository at this point in the history
'server' parameter was not passed, so it was broken when default server required authentication
added missing AJAX operation result check
  • Loading branch information
piotrp committed Nov 3, 2013
1 parent c48b78d commit a75b5a6
Showing 1 changed file with 16 additions and 11 deletions.
27 changes: 16 additions & 11 deletions js/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -727,20 +727,25 @@ function savePrefsToLocalStorage(form)
type: 'POST',
data: {
ajax_request: true,
server: form.find('input[name=server]').val(),
token: form.find('input[name=token]').val(),
submit_get_json: true
},
success: function (response) {
window.localStorage['config'] = response.prefs;
window.localStorage['config_mtime'] = response.mtime;
window.localStorage['config_mtime_local'] = (new Date()).toUTCString();
updatePrefsDate();
$('div.localStorage-empty').hide();
$('div.localStorage-exists').show();
var group = form.parent('.group');
group.css('height', group.height() + 'px');
form.hide('fast');
form.prev('.click-hide-message').show('fast');
success: function (data) {
if (data.success === true) {
window.localStorage['config'] = data.prefs;
window.localStorage['config_mtime'] = data.mtime;
window.localStorage['config_mtime_local'] = (new Date()).toUTCString();
updatePrefsDate();
$('div.localStorage-empty').hide();
$('div.localStorage-exists').show();
var group = form.parent('.group');
group.css('height', group.height() + 'px');
form.hide('fast');
form.prev('.click-hide-message').show('fast');
} else {
PMA_ajaxShowMessage(data.error);
}
},
complete: function () {
submit.prop('disabled', false);
Expand Down

0 comments on commit a75b5a6

Please sign in to comment.