Skip to content

Commit

Permalink
Fix #11639 Bug with the MainBackground Color
Browse files Browse the repository at this point in the history
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
  • Loading branch information
madhuracj committed Nov 4, 2015
1 parent c873c50 commit a9fdf9c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
1 change: 1 addition & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ phpMyAdmin - ChangeLog
- issue #11632 Exporting GIS visualization ignores start and row count
- issue #11476 Errors instead of git info when PHP has no gzip support
- issue #11633 CodeMirror tooltip shows below modal window
- issue #11639 Bug with the MainBackground Color

4.5.1.0 (2015-10-23)
- issue Invalid argument supplied for foreach()
Expand Down
11 changes: 3 additions & 8 deletions themes/pmahomme/css/common.css.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,12 @@
body {
<?php if (! empty($GLOBALS['cfg']['FontFamily'])) { ?>
font-family: <?php echo $GLOBALS['cfg']['FontFamily']; ?>;
<?php
} ?>
<?php } ?>
padding: 0;
margin: 0;
margin-<?php echo $left; ?>: 240px;
color: #444;
background: #fff;
color: <?php echo $GLOBALS['cfg']['MainColor']; ?>;
background: <?php echo $GLOBALS['cfg']['MainBackground']; ?>;

This comment has been minimized.

Copy link
@lem9

lem9 Nov 4, 2015

Contributor

This does not seem to work for me. layout.inc.php is loaded after config.inc.php, so $cfg['MainBackground'] in config.inc.php is not used.

This comment has been minimized.

Copy link
@madhuracj

madhuracj Nov 4, 2015

Author Contributor

See my comment in phpmyadmin/themes#7

}

body#loginform {
Expand Down Expand Up @@ -2798,10 +2797,6 @@
user-select: none;
}

#page_content {
background-color: white;
}

.navigation {
margin: .8em 0;

Expand Down
4 changes: 2 additions & 2 deletions themes/pmahomme/layout.inc.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@
* main frame
*/
// foreground (text) color for the main frame
$GLOBALS['cfg']['MainColor'] = '#000';
$GLOBALS['cfg']['MainColor'] = '#444';

// background for the main frame
$GLOBALS['cfg']['MainBackground'] = '#F5F5F5';
$GLOBALS['cfg']['MainBackground'] = '#fff';

// foreground (text) color of the pointer in browse mode
$GLOBALS['cfg']['BrowsePointerColor'] = '#000';
Expand Down

0 comments on commit a9fdf9c

Please sign in to comment.