Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with dBase extension enabled #14875

Closed
MauricioFauth opened this issue Jan 18, 2019 · 0 comments
Closed

Tests fail with dBase extension enabled #14875

MauricioFauth opened this issue Jan 18, 2019 · 0 comments
Assignees
@williamdes
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted
Milestone
5.0.1

Comments

@MauricioFauth
Copy link
Member

MauricioFauth commented Jan 18, 2019 •
edited by williamdes
Loading

Describe the bug

PHPUnit tests fail with dBase PHP extension enabled.

Affects QA_4_9 and master branches.

To Reproduce

  1. Install dBase extension
  2. Run PHPUnit

Additional context

https://travis-ci.org/phpmyadmin/phpmyadmin/jobs/481601035#L821

1) PhpMyAdmin\Tests\Plugins\Import\ImportShpTest::testImportOsm
Failed asserting that PhpMyAdmin\Message Object &000000005b19305f000000003ebfb4da (
    'number' => 8
    'string' => 'There was an error importing the ESRI shape file: "%s".'
    'message' => ''
    'isDisplayed' => false
    'useBBCode' => true
    'hash' => null
    'params' => Array &0 (
        0 => 'It wasn't possible to find the DBase file "/home/travis/build/phpmyadmin/phpmyadmin/tmp//shp/dresden_osm_shp_gis_osm_transport_a_v06.dbf"'
    )
    'addedMessages' => Array &1 ()
) matches expected ''.

/home/travis/build/phpmyadmin/phpmyadmin/test/classes/Plugins/Import/ImportShpTest.php:84
/home/travis/build/phpmyadmin/phpmyadmin/test/classes/Plugins/Import/ImportShpTest.php:143

2) PhpMyAdmin\Tests\Plugins\Import\ImportShpTest::testDoImport
Failed asserting that PhpMyAdmin\Message Object &000000005b19345a000000003ebfb4da (
    'number' => 8
    'string' => 'There was an error importing the ESRI shape file: "%s".'
    'message' => ''
    'isDisplayed' => false
    'useBBCode' => true
    'hash' => null
    'params' => Array &0 (
        0 => 'It wasn't possible to find the DBase file "/home/travis/build/phpmyadmin/phpmyadmin/tmp//shp/bc_hospitals.dbf"'
    )
    'addedMessages' => Array &1 ()
) matches expected ''.

/home/travis/build/phpmyadmin/phpmyadmin/test/classes/Plugins/Import/ImportShpTest.php:84
/home/travis/build/phpmyadmin/phpmyadmin/test/classes/Plugins/Import/ImportShpTest.php:172
@MauricioFauth MauricioFauth added Bug A problem or regression with an existing feature help wanted labels Jan 18, 2019
bepsvpt added a commit to bepsvpt-fork/phpmyadmin that referenced this issue Jan 6, 2020
@bepsvpt
fix phpmyadmin#14875 - fix shp filename sanitization and update test
9b0a2b9
bepsvpt added a commit to bepsvpt-fork/phpmyadmin that referenced this issue Jan 6, 2020
@bepsvpt
fix phpmyadmin#14875 - fix shp filename sanitization and update test
91fdcde 
Signed-off-by: bepsvpt <og7lsrszah6y3lz@infinitefa.email>
@bepsvpt bepsvpt mentioned this issue Jan 6, 2020
Closed
6 tasks
bepsvpt added a commit to bepsvpt-fork/phpmyadmin that referenced this issue Jan 6, 2020
@bepsvpt
fix phpmyadmin#14875 - fix shp filename sanitization and update test
d4abe4f 
Signed-off-by: bepsvpt <og7lsrszah6y3lz@infinitefa.email>
bepsvpt added a commit to bepsvpt-fork/phpmyadmin that referenced this issue Jan 6, 2020
@bepsvpt
fix phpmyadmin#14875 - fix shp filename sanitization and update test
f577091 
Signed-off-by: bepsvpt <og7lsrszah6y3lz@infinitefa.email>
bepsvpt added a commit to bepsvpt-fork/phpmyadmin that referenced this issue Jan 6, 2020
@bepsvpt
fix phpmyadmin#14875 - fix shp filename sanitization and update test
5a553a3 
Signed-off-by: BePsvPT <og7lsrszah6y3lz@infinitefa.email>
bepsvpt added a commit to bepsvpt-fork/phpmyadmin that referenced this issue Jan 6, 2020
@bepsvpt
fix phpmyadmin#14875 - fix shp filename sanitization and update test
52142f1 
Signed-off-by: PT BePsv <og7lsrszah6y3lz@infinitefa.email>
bepsvpt added a commit to bepsvpt-fork/phpmyadmin that referenced this issue Jan 6, 2020
@bepsvpt
fix phpmyadmin#14875 - fix shp filename sanitization and update test
a140fd9 
Signed-off-by: bepsvpt <og7lsrszah6y3lz@infinitefa.email>
@williamdes williamdes self-assigned this Jan 6, 2020
@williamdes williamdes added this to the 5.0.1 milestone Jan 6, 2020
@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Jan 6, 2020
williamdes pushed a commit to williamdes/phpmyadmintest that referenced this issue Jan 6, 2020
@bepsvpt @williamdes
fix phpmyadmin#14875 - fix shp filename sanitization and update test
16322ef 
Co-authored-by: bepsvpt <og7lsrszah6y3lz@infinitefa.email>

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jan 6, 2020
@williamdes
Merge #15753 - fix #14875 shp import tests where failing
a5ec07f 
Pull-request: #15753
Fixes: #14875
Closes: #15753
Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jan 6, 2020
@williamdes
Add ChangeLog entry for #14875
874c5af
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@williamdes williamdes

Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete help wanted
Projects
None yet
Milestone
5.0.1
Development

Successfully merging a pull request may close this issue.

fix #14875 - fix shp filename sanitization and update test bepsvpt-fork/phpmyadmin
2 participants
@MauricioFauth @williamdes