Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browse doesn't show all records #15387

Open
bm322741 opened this issue Jul 11, 2019 · 19 comments
Open

browse doesn't show all records #15387

bm322741 opened this issue Jul 11, 2019 · 19 comments
Assignees
Labels
affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) Bug A problem or regression with an existing feature
Projects

Comments

@bm322741
Copy link

Describe the bug

Browsing a table, click the >> to go to the last row. The last page isn't the last records in the database. 66,080 records, last calculated page is 2607. Should be 2644 [25 records/page] based on record count.

To Reproduce

Steps to reproduce the behavior:

  1. Browse table
  2. Click on '>>'
  3. Last Page is 2607

Expected behavior

Last page should be 2644.

Screenshots

image
image

Server configuration

  • Operating system: Fedora 29
  • Web server: Apache 2.4.39
  • Database version: MariaDB 10.1.37
  • PHP version: 7.2.19
  • phpMyAdmin version: 4.8.4

Client configuration

  • Browser: Chrome 75.0.3770.100
  • Operating system: Windows 10 1903

Additional context

Add any other context about the problem here.

@williamdes
Copy link
Member

#15100

@williamdes
Copy link
Member

williamdes commented Jul 11, 2019

#15077

@williamdes williamdes marked this as a duplicate of #15077 Jul 11, 2019
@williamdes
Copy link
Member

Fixed by #15094
Thanks for reporting @bm322741
Can you please confirm that the issue does not exist anymore on version 4.9.0.1, you can download 4.9.0.1 on our website

@williamdes williamdes added Bug A problem or regression with an existing feature duplicate labels Jul 11, 2019
@williamdes williamdes self-assigned this Jul 11, 2019
@williamdes williamdes added this to Needs triage in issues via automation Jul 11, 2019
@williamdes williamdes added this to the 4.9.0.1 milestone Jul 11, 2019
@williamdes williamdes added the question Used when we need feedback from the submitter or when the issue is a question about PMA label Jul 11, 2019
@bm322741
Copy link
Author

The same with 4.9.0.1. I tried a repair just in case [no errors reported] but still doesn't get all the records. The page count/last record are exactly the same.

@williamdes
Copy link
Member

@bm322741 Can you try to set $cfg['MaxExactCount'] = 100000; https://docs.phpmyadmin.net/en/latest/config.html#cfg_MaxExactCount

@williamdes williamdes removed duplicate question Used when we need feedback from the submitter or when the issue is a question about PMA labels Jul 11, 2019
@williamdes williamdes removed this from the 4.9.0.1 milestone Jul 11, 2019
@williamdes williamdes marked this as not a duplicate of #15077 Jul 11, 2019
@bm322741
Copy link
Author

Yes. that did it. Is that a bug or just a config issue? I have other tables with 2,000,000 rows.

@williamdes
Copy link
Member

I think this is a config issue, counting rows can take too long on very large tables.

@ibennetch what do you think about it ?

@ibennetch
Copy link
Member

ibennetch commented Jul 12, 2019

I don't think this is quite a bug. It's unfortunate that we have to find some threshold at which to switch from an exact count to an approximate one, but otherwise we run out of resources (especially on shared hosting situations). The solution, as you have seen, is to increase the limit further if your server can support that behavior.

Actually, a bug/feature enhancement that we should investigate here is letting the user go to the very end of records in this case; since this effectively restricted you from the last ~925 records.

I'm not sure off hand what we can do about this, but perhaps on the last page of results we should always perform an exact count.

@bm322741
Copy link
Author

I'm not sure how you handle it internally, but I don't know why you need 80,000 something when I am only showing 25, 50, 100 records at a time. We do it all the time with our web sites. 80,000 records / 25 = 3,200 pages, but I only need to show 1 page so that is 25 items.

For me, most of the time I am interested in the last records inserted so it makes browsing kind of useless for large tables.

@williamdes williamdes moved this from Needs triage to Low priority in issues Aug 11, 2019
@williamdes
Copy link
Member

williamdes commented Sep 11, 2019

Caused my trouble in production where I missed rows, I think the page counter is maybe ok but not the limit of the shown data.

[edit] can not reproduce.

@williamdes williamdes moved this from Low priority to High priority in issues Sep 11, 2019
@williamdes williamdes moved this from High priority to Not reproduced in issues Sep 19, 2019
@williamdes
Copy link
Member

I need a way to reproduce it.

You can refer to data on demo servers (root, no password)

If you reproduce the issue and post you will accelerate the fixing process ;)

@williamdes williamdes removed their assignment Oct 21, 2019
@bm322741
Copy link
Author

bm322741 commented Oct 24, 2019 via email

@williamdes
Copy link
Member

williamdes commented Oct 24, 2019

Thank you so much, I will try the instructions you provided

@williamdes williamdes self-assigned this Oct 24, 2019
@shucon
Copy link
Contributor

shucon commented Jan 25, 2021

I'm not able to reproduce the issue on a 900000 row table. Could it be because the data in each row is not much?
Screenshot from 2021-01-25 23-50-34

@shucon
Copy link
Contributor

shucon commented Jan 25, 2021

I was able to reproduce the issue after restarting the server. In my case it estimated the number of rows to be more than actual and clicking the >> button, it took me an empty row page.

@williamdes
Copy link
Member

williamdes commented Jan 25, 2021

Could you update your screenshot because it is too small to be usable, that said thanks you for the debug you made !

If possible please upload your test table here so other devs can also test it. And let us know your DB and DB version.

@williamdes williamdes moved this from Not reproduced to Reproduced in issues Jan 25, 2021
@williamdes williamdes changed the title browse doesnt show all records browse doesn't show all records Jan 25, 2021
@shucon
Copy link
Contributor

shucon commented Jan 27, 2021

For eg: I had 99999 rows.
Here are the screenshots:
Screenshot from 2021-01-27 16-24-14
On clicking >> button:
Screenshot from 2021-01-27 16-24-32
On manually going to last possible page:
Screenshot from 2021-01-27 16-25-37

@shucon
Copy link
Contributor

shucon commented Jan 27, 2021

Here is the database file:
employee_db.zip

@williamdes williamdes added this to the 5.1.0 milestone Jan 30, 2021
@ibennetch ibennetch modified the milestones: 5.1.0, 5.1.1 Feb 24, 2021
@williamdes williamdes modified the milestones: 5.1.1, 5.1.2 Apr 22, 2021
@williamdes williamdes modified the milestones: 5.1.2, 5.1.3 Jul 27, 2021
@ibennetch ibennetch modified the milestones: 5.1.3, 5.1.4 Feb 11, 2022
@ibennetch ibennetch modified the milestones: 5.1.4, 5.2.1 May 11, 2022
@williamdes williamdes added the affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) label Oct 25, 2022
@williamdes williamdes removed this from the 5.2.1 milestone Oct 25, 2022
@shestakov-vladyslav
Copy link

Oh, I have the same problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) Bug A problem or regression with an existing feature
Projects
issues
  
Reproduced
Development

No branches or pull requests

5 participants