No Option to enter TABLE specific permissions when database name contains _ (underscore)

[Schwuuuuup]

Describe the bug

I was used to grant permissions for single tables instead of permissions for whole databases. For this I opened the useraccount for editing, and klicked on the button "Database" and then on "Table" to select specific Tables for access.
The button "Table" is missing for all Databases with names containing an underscore.

To Reproduce

1. Rename a database to have its name contain underscores like "test_with_underscore"
2. Try to grand table specific permissions:
   User accounts->edit permissions->select "Database" button -> see that there does not appear a button "Table"

See Screenshots

Expected behavior

An underscore in the name should not influence what permissions can be granted.
sie examlpes in the screenshots for "testwithoutunderscore"

Screenshots

Server configuration

• Operating system: Red hat Enterprise Linux 7
• Web server: Apache httpd-2.4.6-95.el7.x86_64
• Database version: MariaDB-server-10.4.16-1.el7.centos.x86_64
• PHP version: PHP 7.3.23 (cli) (built: Oct 1 2020 20:38:17) ( NTS )
• phpMyAdmin version: 5.0.4

Client configuration

• Browser: Vivaldi
• Operating system: MX-Linux

Additional context

The Problem must have showed up some time in the past. I guess it was about half a year ago when I last used this feature and back then it worked fine.

[williamdes]

Hi @Schwuuuuup !
I can confirm this issue, this is quite strange but I reproduced it.

@shucon would you agree to work on this one ?

[shucon]

Sure!!

[ibennetch]

I have not looked at the code yet but have a guess as to what's going on. Since a literal underscore is considered a wildcard, it's likely that we aren't properly escaping it here (like \_), or perhaps are escaping it twice. Again, it's just a guess, but that's where I'd start looking at finding a fix.

[shucon]

I have not looked at the code yet but have a guess as to what's going on. Since a literal underscore is considered a wildcard, it's likely that we aren't properly escaping it here (like \_), or perhaps are escaping it twice. Again, it's just a guess, but that's where I'd start looking at finding a fix.

Thanks @ibennetch , this is exactly what's happening. The database name weren't properly escaped.

[williamdes]

#16481 (review) is part of the fix made for this issue. Making this issue a double issue.
Now fixed in the next release.