Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Table -> VIRTUAL attribute is lost when adding new column #17340

Closed
nunoperalta opened this issue Feb 4, 2022 · 2 comments
Closed

New Table -> VIRTUAL attribute is lost when adding new column #17340

nunoperalta opened this issue Feb 4, 2022 · 2 comments
Assignees
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Milestone

Comments

@nunoperalta
Copy link

Describe the bug

In the New Table page,
The VIRTUAL attribute is lost when we add new column (pressing "Go").
The Expression isn't lost, so if we put the "VIRTUAL" attribute again, the Expression field appears just below, with the saved expression.

The problem is that if you don't notice this after adding a new column,
that column will not be VIRTUAL when you Save/Create the new table.

To Reproduce

Steps to reproduce the behavior:

  1. On a database, press "New"
  2. Add a primary key
  3. Add a "test" field
  4. Select "VIRTUAL" on that "test" field, and add some expression
  5. At the top, press "Go" to add 1 column
  6. "VIRTUAL" is lost in the "test" field.
  7. Press "Save" at the bottom

Expected behavior

"test" field should be VIRTUAL GENERATED

Screenshots

"test" didn't save its VIRTUAL GENERATED attribute

Server configuration

  • Operating system: Docker
  • Web server: Docker
  • Database version: MariaDB 10.5
  • PHP version: Docker
  • phpMyAdmin version: 5.1.2

Client configuration

  • Browser: Google Chrome
  • Operating system: Windows 10

Additional context

sshot-2022-02-04-21-59-17-1

sshot-2022-02-04-21-59-27-1

@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface labels Feb 6, 2022
@williamdes williamdes added this to the 5.1.3 milestone Feb 6, 2022
@williamdes
Copy link
Member

williamdes commented Feb 6, 2022

Hi @nunoperalta
I can confirm this bug, it also occurs with index names: still to be fixed after this is closed

@ibennetch ibennetch modified the milestones: 5.1.3, 5.1.4 Feb 11, 2022
@ibennetch ibennetch modified the milestones: 5.1.4, 5.2.1 May 11, 2022
@williamdes williamdes added the affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) label Oct 25, 2022
@williamdes williamdes removed this from the 5.2.1 milestone Oct 25, 2022
@williamdes williamdes added affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set labels Oct 26, 2022
@williamdes williamdes added this to the 5.2.1 milestone Oct 26, 2022
@williamdes williamdes self-assigned this Nov 20, 2022
@williamdes williamdes added has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete and removed affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set labels Nov 20, 2022
williamdes added a commit that referenced this issue Nov 20, 2022
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes
Copy link
Member

The (phpMyAdmin 5.2+snapshot) also available as a non official docker image is updated with the fix 🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A problem or regression with an existing feature has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete ui Issues relating to the user interface
Projects
None yet
Development

No branches or pull requests

3 participants