Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra table header cell incorrectly added #17869

Open
svivian opened this issue Nov 4, 2022 · 5 comments
Open

Extra table header cell incorrectly added #17869

svivian opened this issue Nov 4, 2022 · 5 comments
Labels
affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) Bug A problem or regression with an existing feature confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set good first issue ui Issues relating to the user interface

Comments

@svivian
Copy link
Contributor

svivian commented Nov 4, 2022 •
edited by williamdes

Describe the bug

View any database table in Browse mode. On the right of the header row there is an extra cell. It's only on the header, not the table body. Image:

Screenshot 2022-11-04 at 13 45 38

In the HTML it's an extra td element like this:

    <td class="d-print-none"><span></span></td>

It doesn't happen on the demo server, but the theming is slightly different on there (in 5.2 it's paler).

Server configuration

  • Operating system: Ubuntu
  • Web server: nginx
  • Database version: 8.0.29-0ubuntu0.20.04.3
  • PHP version: 7.4.3
  • phpMyAdmin version: 5.2.0

Client configuration

  • Browser: Chrome/Firefox
  • Operating system: macOS
@williamdes williamdes added Bug A problem or regression with an existing feature ui Issues relating to the user interface affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set labels Nov 4, 2022
vimalMK added a commit to vimalMK/phpmyadmin that referenced this issue Nov 13, 2022
@vimalMK
Fix phpmyadmin#17869 - Removing the stale table header cell.
e45e2cc 
Signed-off-by: Vimal K <vimalinfo10@gmail.com>
@vimalMK vimalMK mentioned this issue Nov 13, 2022
Closed
6 tasks
@vimalMK
Copy link
Contributor

vimalMK commented Nov 13, 2022

PR #17893. Should fix this issue.

@williamdes williamdes added the has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete label Nov 13, 2022
@williamdes williamdes added this to the 5.2.1 milestone Nov 13, 2022
@williamdes
Copy link
Member

williamdes commented Nov 14, 2022 •
edited

Sources:
76409e2#diff-401fa9ac455f80ecd82d75155b189c586eadf55f976b2050915d031eaf79a39dR2050-R2065
37d50c1#diff-98f45ff6ce5760b40756ed7ce67dc0b880e8ba55f1298d7c79bd7bb8b49a3d60R671-R685

Seems like it goes back 21 years ago into 16843c6 where it was added (16843c6#diff-7b9a476426ac829a8aacf9901ba4cd3d0e6f75fe067defa00be7e5c258f9c6f7R662)

@williamdes
Copy link
Member

Here is the same bug on phpMyAdmin 3.5.0
image

with this HTML

<tr>
    <th colspan="1"><span></span></th>
</tr>

@williamdes
Copy link
Member

On 5.2
with $cfg['RowActionLinks'] = 'both';
Please use the same view and database !
image

@williamdes williamdes removed this from the 5.2.1 milestone Nov 14, 2022
@vimalMK
Copy link
Contributor

vimalMK commented Nov 14, 2022

21 years ago !! wow.

@williamdes williamdes linked a pull request Dec 1, 2022 that will close this issue
Fix #17869 - Removing the stale table header cell. #17893
Closed
6 tasks
@williamdes williamdes mentioned this issue Feb 11, 2023
Open
@williamdes williamdes added good first issue and removed has-pr An issue that has a pull request pending that may fix this issue. The pull request may be incomplete labels Apr 27, 2024
@williamdes williamdes removed a link to a pull request Apr 27, 2024
Fix #17869 - Removing the stale table header cell. #17893
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/5.2 This issue or pull-request affects 5.2.x releases (and maybe further versions) affects/6.0 This issue or pull-request affects 6.0.x releases (and maybe further versions) Bug A problem or regression with an existing feature confirmed/5.2 This issue is confirmed to be reproduced on 5.2 at the time this label was set confirmed/6.0 This issue is confirmed to be reproduced on 6.0 at the time this label was set good first issue ui Issues relating to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #17869 - Removing the stale table header cell. vimalMK/phpmyadmin
3 participants
@svivian @williamdes @vimalMK