Fix #17869 - Removing the stale table header cell.

[vimalMK]

Signed-off-by: Vimal K vimalinfo10@gmail.com

Description

Removing the stale table header cell.

Fixes #17869

Before submitting pull request, please review the following checklist:

• Make sure you have read our CONTRIBUTING.md document.
• Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
• Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
• Every commit has a descriptive commit message.
• Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
• Any new functionality is covered by tests.

[williamdes]

I am looking into this but I feel there was a reason. So for now I am blocking this until I figure out

Sources:
76409e2#diff-401fa9ac455f80ecd82d75155b189c586eadf55f976b2050915d031eaf79a39dR2050-R2065
37d50c1#diff-98f45ff6ce5760b40756ed7ce67dc0b880e8ba55f1298d7c79bd7bb8b49a3d60R671-R685

It goes back 20 years ago ...
What was the reason 🤔

[williamdes]

Seems like it goes back 21 years ago from 16843c6 (16843c6#diff-7b9a476426ac829a8aacf9901ba4cd3d0e6f75fe067defa00be7e5c258f9c6f7R662)

[williamdes]

This fix needs to also delete the line in

phpmyadmin/libraries/classes/Display/Results.php

Line 1315 in e97af75

. '>' . $fullOrPartialTextLink . '</th>';

You need to go to information_schema DB and OPTIMIZER_TRACE view
See: #17869 (comment)

[vimalMK]

This fix needs to also delete the line in

phpmyadmin/libraries/classes/Display/Results.php

Line 1315 in e97af75

. '>' . $fullOrPartialTextLink . '</th>';

You need to go to information_schema DB and OPTIMIZER_TRACE view See: #17869 (comment)

shall I go ahead and remove it now or wait for the update regarding the purpose?

[williamdes]

This fix needs to also delete the line in

phpmyadmin/libraries/classes/Display/Results.php

Line 1315 in e97af75

. '>' . $fullOrPartialTextLink . '</th>';

You need to go to information_schema DB and OPTIMIZER_TRACE view See: #17869 (comment)

shall I go ahead and remove it now or wait for the update regarding the purpose?

I think you can go ahead, please be sure to check as much as possible that it is not breaking something and remove the method param if it is not used anymore

[vimalMK]

This fix needs to also delete the line in

phpmyadmin/libraries/classes/Display/Results.php

Line 1315 in e97af75

. '>' . $fullOrPartialTextLink . '</th>';

You need to go to information_schema DB and OPTIMIZER_TRACE view See: #17869 (comment)

shall I go ahead and remove it now or wait for the update regarding the purpose?

I think you can go ahead, please be sure to check as much as possible that it is not breaking something and remove the method param if it is not used anymore

Sounds good.

[MauricioFauth]

I don't think such change should go to a QA branch.

[williamdes]

I don't think such change should go to a QA branch.

Yeah, it's a bit too risky. Let's merge into master branch

[williamdes]

This has to be re-done, the code has changed too much for me to be able to merge this