Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create indexes with table creation if "IF NOT EXISTS" is on #11419

Merged
merged 1 commit into from
Aug 22, 2015
Merged

Create indexes with table creation if "IF NOT EXISTS" is on #11419

merged 1 commit into from
Aug 22, 2015

Conversation

nisargjhaveri
Copy link
Contributor

No description provided.

@nisargjhaveri nisargjhaveri mentioned this pull request Aug 20, 2015
Closed
@lem9
Copy link
Contributor

lem9 commented Aug 20, 2015

Nisarg,
see my objection in #11407 about the intention we can conclude (or not) due to "IF NOT EXISTS" being checked by default.

@nisargjhaveri
Copy link
Contributor Author

I've updated the PR.

@nisargjhaveri
Create indexes with table creation if "IF NOT EXISTS" is on
b2e8e46 
- change default of IF NOT EXISTS option in export
- Add warning for efficiency with IF NOT EXISTS option

Signed-off-by: Nisarg Jhaveri <nisargjhaveri@gmail.com>
@lem9
Copy link
Contributor

lem9 commented Aug 22, 2015

Nice work.

lem9 added a commit that referenced this pull request Aug 22, 2015
@lem9
Merge pull request #11419 from nisargjhaveri/combine_indexes
569e0c1 
Create indexes with table creation if "IF NOT EXISTS" is on
@lem9 lem9 merged commit 569e0c1 into phpmyadmin:master Aug 22, 2015
@nisargjhaveri nisargjhaveri deleted the combine_indexes branch August 22, 2015 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisargjhaveri @lem9