Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR #1487: Browse Foreign Values should be modal dialog #1180

Merged
merged 1 commit into from
May 15, 2014

Conversation

chirayuchiripal
Copy link
Contributor

Including Test Code.
Signed-off-by: Chirayu Chiripal chirayu.chiripal@gmail.com

Signed-off-by: Chirayu Chiripal <chirayu.chiripal@gmail.com>
@scrutinizer-notifier
Copy link

A new inspection was created.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.28%) when pulling c3f2abe on D-storm:FR-1487 into f334b61 on phpmyadmin:master.

ibennetch added a commit that referenced this pull request May 15, 2014
FR #1487: Browse Foreign Values should be modal dialog
@ibennetch ibennetch merged commit 7cb14af into phpmyadmin:master May 15, 2014
@ibennetch
Copy link
Member

Nice work. Thanks

ibennetch added a commit that referenced this pull request May 15, 2014
@ibennetch
Copy link
Member

Just a reminder to add an entry to ChangeLog. I've already done one for this commit, so don't worry about it for this one; I just mean moving forward.

@chirayuchiripal
Copy link
Contributor Author

Thanks, I will take care of this for upcoming feature requests.

@chirayuchiripal chirayuchiripal deleted the FR-1487 branch September 17, 2014 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants