Fix #11979 DECLARE not accepted as valid SQL #11980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
|
Are parse errors reported correctly after this change? (Validating another string than is in the input) |
|
The body of a stored procedure does not seem to be parsed at all. Above SQL on the SQL window does not generate any Lint errors. |
|
True, then this is definitely safe... |
nijel
added a commit
that referenced
this pull request
Feb 19, 2016
Fix #11979 DECLARE not accepted as valid SQL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one way of handling the bug. Here I try to pass the complete SQL for the creation of routine/trigger/event to the Linter by adding dummy values for the options.