Create .user.ini #12917

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@edwarddekker
edwarddekker commented Jan 22, 2017 edited

Signed-off-by: Edward Dekker github@edwarddekker.nl

@edwarddekker edwarddekker Create .user.ini
Limit the upload and download size of your files.
be22fdb
@edwarddekker

Signed-off-by: Edward Dekker github@edwarddekker.nl

@codecov-io
codecov-io commented Jan 22, 2017 edited

Current coverage is 54.18% (diff: 100%)

Merging #12917 into master will not change coverage

@@             master     #12917   diff @@
==========================================
  Files           466        466          
  Lines         69633      69633          
  Methods        2126       2126          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          37734      37734          
  Misses        31899      31899          
  Partials          0          0          

Powered by Codecov. Last update b2e2e77...be22fdb

@ibennetch
Contributor

I think we should leave this up to the user to manage as we can't guess reasonable defaults not make configuration files that apply to all server configurations.

@nijel
Member
nijel commented Jan 23, 2017

Some time ago, we're removed .htaccess files as this approach applies only to one of webservers and it's not really possible for us to maintain configurations for all webservers people use.

Also imposing arbitrary limits here might be confusing for users having this properly configured at system level.

Overall I don't think we should include configuration for any webserver, this is really something person installing phpMyAdmin should take care of (depending on expected usage of phpMyAdmin and web server resources).

PS: Technically speaking, setting lower limit on post_max_size than upload_max_filesize is wrong, it should be other way, see http://php.net/manual/en/ini.core.php#ini.post-max-size.

@nijel nijel closed this Jan 23, 2017
@nijel nijel self-assigned this Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment