Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix errors due to undefined variables #14208
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 18, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #14208 +/- ##
=========================================
Coverage 52.89% 52.89%
Complexity 14353 14353
=========================================
Files 492 492
Lines 63664 63664
=========================================
Hits 33675 33675
Misses 29989 29989 |
This comment has been minimized.
This comment has been minimized.
|
Very similar to e64c50a although this pull request also changes https://github.com/phpmyadmin/phpmyadmin/pull/14208/files#diff-784ca0aad90bec9846c81577bbf2518fL222 which is not resolved in that commit, so perhaps there's more to be done here. @mauriciofauth could you take a look? |
mauriciofauth
merged commit ea5c066
into
phpmyadmin:master
Apr 19, 2018
4 of 6 checks passed
DCO
Expected "CommanderRoot <commanderroot@users.noreply.github.com>", but got "Tobias Speicher <rootcommander@gmail.com>".
Details
codecov/patch
0% of diff hit (target 52.89%)
Details
Codacy/PR Quality Review
Up to standards. A positive pull request.
Details
Scrutinizer
Analysis: No new issues – Tests: passed
Details
codecov/project
52.89% remains the same compared to 2cde312
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Merged, thanks for your contribution! |
mauriciofauth
self-assigned this
Apr 19, 2018
mauriciofauth
added this to the 5.0.0 milestone
Apr 19, 2018
CommanderRoot
deleted the
CommanderRoot:patch-1
branch
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
CommanderRoot commentedApr 18, 2018
Before submitting pull request, please check that every commit:
This fixes these errors messages I'm getting:
