New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors due to undefined variables #14208

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
3 participants
@CommanderRoot
Contributor

CommanderRoot commented Apr 18, 2018

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

This fixes these errors messages I'm getting:
grafik

Fix errors due to undefined variables
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Apr 18, 2018

Codecov Report

Merging #14208 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #14208   +/-   ##
=========================================
  Coverage     52.89%   52.89%           
  Complexity    14353    14353           
=========================================
  Files           492      492           
  Lines         63664    63664           
=========================================
  Hits          33675    33675           
  Misses        29989    29989
@ibennetch

This comment has been minimized.

Member

ibennetch commented Apr 19, 2018

Very similar to e64c50a although this pull request also changes https://github.com/phpmyadmin/phpmyadmin/pull/14208/files#diff-784ca0aad90bec9846c81577bbf2518fL222 which is not resolved in that commit, so perhaps there's more to be done here. @mauriciofauth could you take a look?

@mauriciofauth mauriciofauth merged commit ea5c066 into phpmyadmin:master Apr 19, 2018

4 of 6 checks passed

DCO Expected "CommanderRoot <commanderroot@users.noreply.github.com>", but got "Tobias Speicher <rootcommander@gmail.com>".
Details
codecov/patch 0% of diff hit (target 52.89%)
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/project 52.89% remains the same compared to 2cde312
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Apr 19, 2018

Merged, thanks for your contribution!
And sorry! I ended up committing e64c50a before seeing this PR.

@mauriciofauth mauriciofauth self-assigned this Apr 19, 2018

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Apr 19, 2018

@CommanderRoot CommanderRoot deleted the CommanderRoot:patch-1 branch Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment