Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors due to undefined variables #14208

merged 1 commit into from Apr 19, 2018


Copy link

@CommanderRoot CommanderRoot commented Apr 18, 2018

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

This fixes these errors messages I'm getting:

Signed-off-by: Tobias Speicher <>
Copy link

@codecov codecov bot commented Apr 18, 2018

Codecov Report

Merging #14208 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #14208   +/-   ##
  Coverage     52.89%   52.89%           
  Complexity    14353    14353           
  Files           492      492           
  Lines         63664    63664           
  Hits          33675    33675           
  Misses        29989    29989
Copy link

@ibennetch ibennetch commented Apr 19, 2018

Very similar to e64c50a although this pull request also changes which is not resolved in that commit, so perhaps there's more to be done here. @mauriciofauth could you take a look?

@mauriciofauth mauriciofauth merged commit ea5c066 into phpmyadmin:master Apr 19, 2018
4 of 6 checks passed
4 of 6 checks passed
DCO Expected "CommanderRoot <>", but got "Tobias Speicher <>".
codecov/patch 0% of diff hit (target 52.89%)
Codacy/PR Quality Review Up to standards. A positive pull request.
Scrutinizer Analysis: No new issues – Tests: passed
codecov/project 52.89% remains the same compared to 2cde312
continuous-integration/travis-ci/pr The Travis CI build passed
Copy link

@mauriciofauth mauriciofauth commented Apr 19, 2018

Merged, thanks for your contribution!
And sorry! I ended up committing e64c50a before seeing this PR.

@mauriciofauth mauriciofauth self-assigned this Apr 19, 2018
@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Apr 19, 2018
@CommanderRoot CommanderRoot deleted the CommanderRoot:patch-1 branch Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.