more css cleanup

[ghost]

even more css code cleanup.

some code standards and automated formating would be nice to see and have. not sure if this is easy to realize.

please review my changes and have a good day :)

[codecov]

Codecov Report

Merging #14510 into master will increase coverage by <.01%.
The diff coverage is 0.68%.

@@             Coverage Diff              @@
##             master   #14510      +/-   ##
============================================
+ Coverage     50.44%   50.45%   +<.01%     
  Complexity    14428    14428              
============================================
  Files           500      500              
  Lines         67841    67828      -13     
============================================
  Hits          34220    34220              
+ Misses        33621    33608      -13

[ghost]

why is it not working?
and why are there commits done by @ibennetch ?

[williamdes]

@BO41 you need to rebase on master :)

[ibennetch]

My guess is that you started working and then somehow added more updated commits after I pushed those to master. Perhaps with git merge. Regardless, it seems like they've somehow also changed the commit ID (the hash) which is why they're showing here as new commits.

Probably the cleanest way to fix it is for either you or whomever merges this to use git cherry-pick to take only your two commits from this branch.

When you're updating a branch with changes from origin/master, but already have changes, I prefer git rebase origin/master as that preserves your changes and doesn't clutter the log with merge commits.

[ghost]

@ibennetch I hope I fixed most of it now (with a lot of help of @williamdes , thx :))

[ghost]

...still failing 😢

if someone can help me, again

[williamdes]

@BO41 Do not worry codecov/patch often fails for no good reason, I still do not understand what that is.

@ibennetch What is the purpose of codecov/patch ?

[ghost]

@williamdes should I be worried about DCOs failing?

[williamdes]

@BO41 Yes !
I use the following command to fix all my commits before pushing them to remote
git rebase --exec 'git commit --amend --no-edit --no-verify --gpg-sign --signoff' origin/master
If you dont have a gpg key ommit --gpg-sign

@ibennetch @nijel Just a question : why do you not use your GPG key to sign commits ?

[ghost]

replaced with #14532