Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup for Server, Database and table related revamped files #14583

Closed
wants to merge 298 commits into from
Closed

Code cleanup for Server, Database and table related revamped files #14583

wants to merge 298 commits into from

Conversation

Piyush3079
Copy link
Contributor

This pr contains some duplicate code removal for sever, database and table related files which have been revamped and tested locally.

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

nijel and others added 30 commits July 23, 2018 12:51
@nijel
Fix typo in translation
caa7b30 
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel
Merge remote-tracking branch 'origin/QA_4_8'
e245019
@nijel
Merge branch 'QA_4_8'
fd3e450
@nijel @weblate
Translated using Weblate (Portuguese)
94d4990 
Currently translated at 57.3% (1889 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/pt/
Signed-off-by: Michal Čihař <michal@cihar.com>
@ibennetch @weblate
Translated using Weblate (Lithuanian)
d52400f 
Currently translated at 40.2% (1323 of 3288 strings)

[CI skip]

Translation: phpMyAdmin/4.8
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-8/lt/
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@dancaragea @weblate
Translated using Weblate (Romanian)
0e297ae 
Currently translated at 41.7% (1375 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/ro/
Signed-off-by: Dan Caragea <dan_caragea@yahoo.com>
@nijel @weblate
Translated using Weblate (Uyghur)
27cf887 
Currently translated at 9.7% (321 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/ug/
Signed-off-by: Michal Čihař <michal@cihar.com>
@weblate
Merge branch 'origin/master' into Weblate
065ea95
@dancaragea @weblate
Translated using Weblate (Romanian)
22fffb8 
Currently translated at 41.9% (1379 of 3288 strings)

[CI skip]

Translation: phpMyAdmin/4.8
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-8/ro/
Signed-off-by: Dan Caragea <dan_caragea@yahoo.com>
@nijel @weblate
Translated using Weblate (Lithuanian)
0eb9438 
Currently translated at 39.9% (1316 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/lt/
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel @weblate
Translated using Weblate (Chinese (Simplified))
66bdca3 
Currently translated at 84.0% (2762 of 3288 strings)

[CI skip]

Translation: phpMyAdmin/4.8
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-8/zh_Hans/
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel @weblate
Translated using Weblate (Czech)
3c55adf 
Currently translated at 89.9% (2958 of 3288 strings)

[CI skip]

Translation: phpMyAdmin/4.8
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-8/cs/
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel @weblate
Translated using Weblate (Lithuanian)
fc4852d 
Currently translated at 40.3% (1326 of 3288 strings)

[CI skip]

Translation: phpMyAdmin/4.8
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-8/lt/
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel @weblate
Translated using Weblate (Portuguese)
6266466 
Currently translated at 57.1% (1879 of 3288 strings)

[CI skip]

Translation: phpMyAdmin/4.8
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-8/pt/
Signed-off-by: Michal Čihař <michal@cihar.com>
@dancaragea @weblate
Translated using Weblate (Romanian)
4f0e14d 
Currently translated at 42.3% (1393 of 3288 strings)

[CI skip]

Translation: phpMyAdmin/4.8
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-8/ro/
Signed-off-by: Dan Caragea <dan_caragea@yahoo.com>
@nijel @weblate
Translated using Weblate (Croatian)
7efcc10 
Currently translated at 26.8% (882 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/hr/
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel @weblate
Translated using Weblate (Czech)
21324f6 
Currently translated at 89.7% (2955 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/cs/
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel @weblate
Translated using Weblate (Lithuanian)
7590087 
Currently translated at 41.7% (1373 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/lt/
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel @weblate
Translated using Weblate (Malayalam)
5b8425a 
Currently translated at 1.7% (57 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/ml/
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel @weblate
Translated using Weblate (Polish)
1ee7bab 
Currently translated at 94.8% (3120 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/pl/
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel @weblate
Translated using Weblate (Romanian)
e9897ec 
Currently translated at 42.2% (1390 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/ro/
Signed-off-by: Michal Čihař <michal@cihar.com>
@dancaragea @weblate
Translated using Weblate (Romanian)
84ba38a 
Currently translated at 42.2% (1390 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/ro/
Signed-off-by: Dan Caragea <dan_caragea@yahoo.com>
@nijel @weblate
Translated using Weblate (Spanish)
77a65a6 
Currently translated at 97.7% (3218 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/es/
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel @weblate
Translated using Weblate (Uyghur)
bb8158a 
Currently translated at 9.8% (323 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/ug/
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel
Merge remote-tracking branch 'weblate-4.8/QA_4_8' into QA_4_8
097ff68
@nijel
Merge branch 'QA_4_8'
edb4087
@dancaragea @weblate
Translated using Weblate (Romanian)
8ac1f0c 
Currently translated at 42.2% (1392 of 3291 strings)

[CI skip]

Translation: phpMyAdmin/Development
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/master/ro/
Signed-off-by: Dan Caragea <dan_caragea@yahoo.com>
@weblate
Merge branch 'origin/master' into Weblate
3c27dc1
@dancaragea @weblate
Translated using Weblate (Romanian)
00b6d3f 
Currently translated at 42.4% (1396 of 3288 strings)

[CI skip]

Translation: phpMyAdmin/4.8
Translate-URL: https://hosted.weblate.org/projects/phpmyadmin/4-8/ro/
Signed-off-by: Dan Caragea <dan_caragea@yahoo.com>
@weblate
Merge branch 'origin/QA_4_8' into Weblate
ac76b08
@Piyush3079
Replace .js extension from db_export and db_import.
2405047 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Resolve merge conflicts and some code cleanup for functions.js
12830dd 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Bug fix for multi table actions on db_structure.php
7c0c5b1 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Add PMA_showHints function in show_ajax_messages.js in js/src/utils a…
0f357d4 
…nd PMA_initSlider in Slider.js.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Modular code for indexes.js being used on different pages.
e3c7b29 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Remove .js extension from php files for indexes.js to allow dynami im…
a4c577d 
…port.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Modular code for tbl_structure.js
1f6f39c 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Remove .js extension from tbl_structure.php related files to allow dy…
619850b 
…namic imports.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Modular code for tbl_relation.php.
9261357 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Remove .js extension from tbl_relation.php related files for dynamic …
2e362e1 
…loading.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Modular code for tbl_chart for dawing charts on Table Browsing
d339aa6 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Remove .js extension from files and remove jqplot plugins which are n…
e91e72c 
…ot deened to be loaded in head of page.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Modular code for tbl_operations.php
30dd9bc 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Remove .js extention from tbl_operations.php file to allow dynamic im…
2ab4cd8 
…port.

Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Modular code for tbl_tracking.php
ee6c226 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Modular code for tbl_change.php.
9a93a9e 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Edit php files for changes related to tbl_change.js
65fb420 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Modular code for tbl_select.js
dafe655 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Modular code for tbl_find_replace.php
5d664b3 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Resolve merge conflicts and add tbl import and export in modular code
e90a002 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Sync the branch with master.
b6b2fda 
Remove server related files for code cleanup.
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Code restructuring and comments for serve related files.
d73df6a 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Remove table related files not needed in modular code.
ac4cb63 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@Piyush3079
Some code structuring for table related files.
f0e8a1a 
Signed-Off-By: Piyush Vijay <piyushvijay.1997@gmail.com>
@phpmyadmin-bot
Copy link
Contributor

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@Piyush3079 Piyush3079 changed the base branch from master to gsoc-js-refactoring August 21, 2018 00:17
@phpmyadmin-bot
Copy link
Contributor

This pull requests contains too many commits, in most cases it is caused by wrong merge target. In case you have forked master branch you should also ask merging to master branch. See GitHub documentation for more details.

@Piyush3079 Piyush3079 closed this Aug 21, 2018
@Piyush3079
Copy link
Contributor Author

Wrong rebase merge made in this pr so closing this.

@Piyush3079 Piyush3079 deleted the Mod_Js_DST_Cleanup branch August 21, 2018 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet