Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version handling for the dev packages in Composer when creating the release #14785

Merged
merged 1 commit into from
Dec 23, 2018

Conversation

ibennetch
Copy link
Member

This parses the required dependency versions from composer.json and installs them manually as required packages.

Fixes #14782

Signed-off-by: Isaac Bennetch bennetch@gmail.com

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link

@farzadarab farzadarab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can not sigh in to my iphon accunt

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #14785 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #14785      +/-   ##
============================================
- Coverage     50.97%   50.96%   -0.01%     
- Complexity    14027    14028       +1     
============================================
  Files           473      473              
  Lines         65304    65313       +9     
============================================
  Hits          33288    33288              
- Misses        32016    32025       +9

@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #14785 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14785   +/-   ##
=========================================
  Coverage     50.97%   50.97%           
  Complexity    14027    14027           
=========================================
  Files           473      473           
  Lines         65304    65304           
=========================================
  Hits          33288    33288           
  Misses        32016    32016

…he release.

This parses the required dependency versions from composer.json and installs them manually as required packages.

Fixes phpmyadmin#14782

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@ibennetch
Copy link
Member Author

I've updated this a bit and think it's better now.

@ibennetch
Copy link
Member Author

@farzadarab are you talking about phpMyAdmin? We don't have a native iPhone app so I'm a bit confused.

@ibennetch ibennetch merged commit 0a0bc2c into phpmyadmin:master Dec 23, 2018
@ibennetch ibennetch added this to the 5.0.0 milestone Dec 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants