Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gsoc bootstrap #15299

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
4 participants
@murex971
Copy link
Contributor

commented Jun 2, 2019

Description

Please describe your pull request.

Fixes indentation of index.twig

mauriciofauth and others added some commits May 31, 2019

Replace jQuery .bind() with .on()
As of jQuery 3.0, .bind() has been deprecated.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
first commit
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Inject dependencies (#15271)
Inject dependencies instead of building them.

Signed-off-by: Hugues Peccatte <hugues.peccatte@gmail.com>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Add ChangeLog entry for #15266
External dependency injection system

[ci skip]

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on 0a6c043 Jun 2, 2019

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/home/index.twig

fixes indentation and tags
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>

@murex971 murex971 force-pushed the murex971:gsoc-bootstrap branch from 9bc7b53 to 3c27ee7 Jun 2, 2019

@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on 3c27ee7 Jun 2, 2019

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: templates/home/index.twig

@codecov

This comment has been minimized.

Copy link

commented Jun 2, 2019

Codecov Report

Merging #15299 into gsoc-bootstrap will decrease coverage by <.01%.
The diff coverage is 27.32%.

@@                 Coverage Diff                  @@
##             gsoc-bootstrap   #15299      +/-   ##
====================================================
- Coverage             52.76%   52.75%   -0.01%     
- Complexity            14068    14071       +3     
====================================================
  Files                   484      484              
  Lines                 62214    62216       +2     
====================================================
- Hits                  32826    32825       -1     
- Misses                29388    29391       +3
1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Jun 2, 2019

Codecov Report

Merging #15299 into gsoc-bootstrap will decrease coverage by <.01%.
The diff coverage is 27.32%.

@@                 Coverage Diff                  @@
##             gsoc-bootstrap   #15299      +/-   ##
====================================================
- Coverage             52.76%   52.75%   -0.01%     
- Complexity            14068    14071       +3     
====================================================
  Files                   484      484              
  Lines                 62214    62216       +2     
====================================================
- Hits                  32826    32825       -1     
- Misses                29388    29391       +3
bootstrap grid applied to plugin page
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@murex971

This comment has been minimized.

Copy link
Contributor Author

commented Jun 2, 2019

The newly added grid structure to the plugins page allows the user to see complete tables irrespective of the size of browser window by applying horizontal scrolling only when size of window reduces than the size of tables.

@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Jun 6, 2019

Closed in favor of #15302

@mauriciofauth mauriciofauth self-assigned this Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.