Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

card classes added to home page #15369

Closed
wants to merge 3 commits into from
Closed

Conversation

@murex971
Copy link
Contributor

@murex971 murex971 commented Jul 2, 2019

Signed-off-by: Nupur Agrawal nupur202000@gmail.com

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
Copy link
Member

@williamdes williamdes left a comment

LGTM

@mauriciofauth
Copy link
Member

@mauriciofauth mauriciofauth commented Jul 2, 2019

@sudo-bot Deploy pull request

@sudo-robot
Copy link

@sudo-robot sudo-robot commented Jul 2, 2019

Deployed (phpmyadmin-pr-15369): card-application commit: 735a5eb6eac42a6274e849329d54de9d35057a1b

url: https://phpmyadmin-pr-15369.wdes.eu.org
user: public
user: public


Deploy finished

@mauriciofauth mauriciofauth self-assigned this Jul 2, 2019
@mauriciofauth mauriciofauth changed the base branch from gsoc-bootstrap to master Jul 12, 2019
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@codecov
Copy link

@codecov codecov bot commented Jul 19, 2019

Codecov Report

Merging #15369 into master will increase coverage by 0.18%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #15369      +/-   ##
============================================
+ Coverage     52.53%   52.72%   +0.18%     
- Complexity    13956    14071     +115     
============================================
  Files           483      484       +1     
  Lines         61872    62131     +259     
============================================
+ Hits          32506    32760     +254     
- Misses        29366    29371       +5

Copy link
Member

@mauriciofauth mauriciofauth left a comment

Can you rebase with master branch and fix the conflicts?

@williamdes williamdes added this to To do in pull-requests Aug 20, 2019
@williamdes williamdes moved this from To do to GSOC in pull-requests Aug 20, 2019
</a>
</li>
<li id="li_pma_changes">
<a href="changelog.php{{ get_common() }}" target="_blank">
Copy link
Member

@mauriciofauth mauriciofauth Aug 30, 2019

Suggested change
<a href="changelog.php{{ get_common() }}" target="_blank">
<a href="{{ url('/changelog') }}" target="_blank">

</a>
</li>
<li id="li_pma_license">
<a href="license.php{{ get_common() }}" target="_blank">
Copy link
Member

@mauriciofauth mauriciofauth Aug 30, 2019

Suggested change
<a href="license.php{{ get_common() }}" target="_blank">
<a href="{{ url('/license') }}" target="_blank">

templates/preferences/manage/main.twig Show resolved Hide resolved
templates/preferences/manage/main.twig Show resolved Hide resolved
templates/preferences/two_factor/main.twig Show resolved Hide resolved
templates/preferences/two_factor/main.twig Show resolved Hide resolved
themes/pmahomme/scss/_common.scss Outdated Show resolved Hide resolved
pull-requests automation moved this from GSOC to Review in progress Aug 30, 2019
Signed-off-by: Nupur Agrawal <nupur202000@gmail.com>
@murex971 murex971 force-pushed the card-application branch from 498a39c to 2c6d46e Aug 31, 2019
@stale
Copy link

@stale stale bot commented Oct 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 31, 2019
@stale stale bot closed this Nov 7, 2019
pull-requests automation moved this from Review in progress to Done Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
pull-requests
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants