Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing the 'Save Page As' of the designer section #15423

Open
wants to merge 2 commits into
base: master
from

Conversation

@Bournvita1998
Copy link
Contributor

commented Aug 7, 2019

Description

Automatically toggle the radio button to "Create a page and save it" when the user clicks the bottom text box

Here are the screenshots after making the changes to the code:

[Before clicking "Create a page and save it"]
Selection_064

[After clicking "Create a page and save it"]
Selection_066

Fixes #13371

Signed-off-by: Mohit Kuri mohit.kuri@research.iiit.ac.in

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Bournvita1998 added some commits Aug 3, 2019

Enhamcement of the designer's save as
Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>
Automatically toggle the radio button to "Create a page and save it" …
…when the use clicks the bottom text box

Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>

@Bournvita1998 Bournvita1998 changed the title Save as Enhancing the 'Save Page As' of the designer section Aug 7, 2019

@shucon

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

@sudo-bot Deploy PR

@sudo-bot

This comment has been minimized.

Copy link

commented Aug 7, 2019

Deployed (phpmyadmin-pr-15423): Save_as commit: f13329420c19188ae2ee140444f10e5d2cd57733

url: https://phpmyadmin-pr-15423.wdes.eu.org
user: public
user: public


Deploy finished

1 similar comment
@sudo-bot

This comment has been minimized.

Copy link

commented Aug 7, 2019

Deployed (phpmyadmin-pr-15423): Save_as commit: f13329420c19188ae2ee140444f10e5d2cd57733

url: https://phpmyadmin-pr-15423.wdes.eu.org
user: public
user: public


Deploy finished

@shucon

shucon approved these changes Aug 7, 2019

@shucon

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

LGTM

@williamdes williamdes added this to To do in pull-requests Aug 20, 2019

@williamdes williamdes moved this from To do to Review in progress in pull-requests Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.