Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancing the 'Save Page As' of the designer section #15423

Merged
merged 1 commit into from
Feb 23, 2020
Merged

Enhancing the 'Save Page As' of the designer section #15423

merged 1 commit into from
Feb 23, 2020

Conversation

Bournvita1998
Copy link
Contributor

@Bournvita1998 Bournvita1998 commented Aug 7, 2019 •
edited
Loading

Description

Automatically toggle the radio button to "Create a page and save it" when the user clicks the bottom text box

Here are the screenshots after making the changes to the code:

[Before clicking "Create a page and save it"]
Selection_064

[After clicking "Create a page and save it"]
Selection_066

Fixes #13371

Signed-off-by: Mohit Kuri mohit.kuri@research.iiit.ac.in

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

@Bournvita1998 Bournvita1998 changed the title Save as Enhancing the 'Save Page As' of the designer section Aug 7, 2019
@shucon
Copy link
Contributor

shucon commented Aug 7, 2019

@sudo-bot Deploy PR

@sudo-robot
Copy link

sudo-robot commented Aug 7, 2019 •
edited
Loading

Deployed (phpmyadmin-pr-15423): Save_as commit: f13329420c19188ae2ee140444f10e5d2cd57733

url: https://phpmyadmin-pr-15423.wdes.eu.org
user: public
user: public

Deploy finished

1 similar comment
@sudo-robot
Copy link

sudo-robot commented Aug 7, 2019 •
edited
Loading

Deployed (phpmyadmin-pr-15423): Save_as commit: f13329420c19188ae2ee140444f10e5d2cd57733

url: https://phpmyadmin-pr-15423.wdes.eu.org
user: public
user: public

Deploy finished

@shucon
Copy link
Contributor

shucon commented Aug 7, 2019

LGTM

@williamdes williamdes added this to To do in pull-requests Aug 20, 2019
@williamdes williamdes moved this from To do to Review in progress in pull-requests Aug 20, 2019
@stale
Copy link

stale bot commented Oct 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 6, 2019
@stale stale bot closed this Oct 13, 2019
pull-requests automation moved this from Review in progress to Done Oct 13, 2019
@shucon
Copy link
Contributor

shucon commented Oct 14, 2019

@ibennetch @williamdes I think this PR is ready to be merged.

@williamdes williamdes reopened this Oct 14, 2019
pull-requests automation moved this from Done to To do Oct 14, 2019
@stale stale bot removed the wontfix label Oct 14, 2019
@phpmyadmin phpmyadmin deleted a comment from zeenayouhan Oct 25, 2019
@williamdes williamdes moved this from To do to In progress in pull-requests Dec 10, 2019
@williamdes williamdes moved this from In progress to Review in progress in pull-requests Dec 10, 2019
@stale
Copy link

stale bot commented Dec 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 24, 2019
@stale stale bot closed this Dec 31, 2019
pull-requests automation moved this from Review in progress to Done Dec 31, 2019
@williamdes williamdes reopened this Dec 31, 2019
pull-requests automation moved this from Done to To do Dec 31, 2019
@williamdes williamdes self-assigned this Dec 31, 2019
@williamdes williamdes moved this from To do to Review in progress in pull-requests Jan 10, 2020
@Bournvita1998 @williamdes
Automatically toggle the radio button to "Create a page and save it" …
f2db7b5 
…when the use clicks the bottom text box

Signed-off-by: Mohit Kuri <mohit.kuri@research.iiit.ac.in>
pull-requests automation moved this from Review in progress to Reviewer approved Feb 23, 2020
williamdes
williamdes approved these changes Feb 23, 2020
View reviewed changes
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine 💯

@williamdes williamdes merged commit dc9a8dd into phpmyadmin:master Feb 23, 2020
pull-requests automation moved this from Reviewer approved to Done Feb 23, 2020
@williamdes williamdes added enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface labels Feb 23, 2020
@williamdes williamdes added this to the 5.1.0 milestone Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

@shucon shucon shucon approved these changes

Assignees

@williamdes williamdes

Labels
enhancement A feature request for improving phpMyAdmin ui Issues relating to the user interface
Projects
pull-requests
  
Done
Milestone
5.1.0
4 participants
@Bournvita1998 @shucon @sudo-robot @williamdes