-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid extension alert and clear input #15595
Invalid extension alert and clear input #15595
Conversation
Signed-off-by: Md Shifaul Islam <shifat.it@gmail.com>
Please proceed . Existing flow is ok . Just an alert given for invalid extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do a php server side check
But this check is restricting users as @ibennetch said
Signed-off-by: Md Shifaul Islam <shifat.it@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #15595 +/- ##
=========================================
Coverage 52.98% 52.98%
Complexity 14051 14051
=========================================
Files 476 476
Lines 61362 61362
=========================================
Hits 32515 32515
Misses 28847 28847 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the server side fix !
Sorry but I will not merge this PR I hope that I did not misunderstand something. |
Signed-off-by: Md Shifaul Islam shifat.it@gmail.com
Description
Invalid extension alert and clear input to upload valid files again.
Fixes #15541
Before submitting pull request, please review the following checklist:
Signed-off-by
line as described in our DCO. This ensures that the work you're submitting is your own creation.