Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid extension alert and clear input #15595

Closed

Conversation

tlshifat
Copy link

@tlshifat tlshifat commented Nov 25, 2019

Signed-off-by: Md Shifaul Islam shifat.it@gmail.com

Description

Invalid extension alert and clear input to upload valid files again.

Fixes #15541

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

Signed-off-by: Md Shifaul Islam <shifat.it@gmail.com>
@tlshifat
Copy link
Author

Please proceed . Existing flow is ok . Just an alert given for invalid extension.
Hope this will help.

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a php server side check

But this check is restricting users as @ibennetch said

Signed-off-by: Md Shifaul Islam <shifat.it@gmail.com>
@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #15595 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #15595   +/-   ##
=========================================
  Coverage     52.98%   52.98%           
  Complexity    14051    14051           
=========================================
  Files           476      476           
  Lines         61362    61362           
=========================================
  Hits          32515    32515           
  Misses        28847    28847

Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the server side fix !

@williamdes williamdes added this to In progress in pull-requests via automation Dec 5, 2019
@williamdes williamdes moved this from In progress to blocked in pull-requests Dec 5, 2019
@williamdes williamdes self-assigned this Jan 16, 2020
@williamdes
Copy link
Member

williamdes commented Jan 16, 2020

Sorry but I will not merge this PR
IMO users do what they want and if they upload bad files no problem if it does not introduce a security issue.

I hope that I did not misunderstand something.

@williamdes williamdes closed this Jan 16, 2020
pull-requests automation moved this from blocked to Done Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
pull-requests
  
Done
Development

Successfully merging this pull request may close these issues.

restrict some types of uploads
3 participants