-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract NavigationTree->fastFilterHtml()'s HTML to Twig #16878
Extract NavigationTree->fastFilterHtml()'s HTML to Twig #16878
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16878 +/- ##
=========================================
Coverage 56.61% 56.61%
+ Complexity 15146 15140 -6
=========================================
Files 475 475
Lines 60537 60499 -38
=========================================
- Hits 34270 34251 -19
+ Misses 26267 26248 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
I left one small comment
Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com> Extract NavigationTree->fastFilter, create twig Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com> Remove debug data Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com> Rename variables and refactor template logic Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com> Remove unnecessary ternary Signed-off-by: Daniel Tiringer <tiringerdaniel@tutanota.com>
Merged, thanks for your contribution! |
Description
Extract HTML from
libraries/classes/Navigation/NavigationTree.php
'sfastFilterHtml()
to Twig templatesRef #14801
Before submitting pull request, please review the following checklist:
Signed-off-by
line as described in our DCO. This ensures that the work you're submitting is your own creation.