Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17033 - scaling of line width and point size in gis visualization #17041

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

MoonE
Copy link
Contributor

@MoonE MoonE commented Jul 26, 2021

Scale the svg lines and points with the scale so the line width / point size is always the same on screen.
Fixes #17033

Don't perform double click action when clicking on the controls.

Signed-off-by: Maximilian Krög maxi_kroeg@web.de

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #17041 (01f2381) into QA_5_1 (7ef1c5f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             QA_5_1   #17041   +/-   ##
=========================================
  Coverage     57.10%   57.10%           
  Complexity    15300    15300           
=========================================
  Files           471      471           
  Lines         62113    62113           
=========================================
  Hits          35468    35468           
  Misses        26645    26645           
Flag Coverage Δ
arch-7-amd64 60.58% <ø> (ø)
arch-7-arm32v6 60.47% <ø> (ø)
arch-7-arm32v7 60.47% <ø> (ø)
arch-7-arm64v8 60.58% <ø> (ø)
arch-7-i386 60.47% <ø> (ø)
arch-7-s390x 60.44% <ø> (ø)
dbase-extension 56.78% <ø> (ø)
recode-extension 56.74% <ø> (ø)
unit-7.1-ubuntu-latest 56.74% <ø> (ø)
unit-7.2-ubuntu-latest 56.93% <ø> (ø)
unit-7.3-ubuntu-latest 60.61% <ø> (ø)
unit-7.4-ubuntu-latest 60.61% <ø> (ø)
unit-8.0-ubuntu-latest 60.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef1c5f...01f2381. Read the comment docs.

@williamdes williamdes added this to In progress in pull-requests via automation Jul 27, 2021
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good but are quite large so I will have to test it intensively

pull-requests automation moved this from In progress to Reviewer approved Jul 27, 2021
@williamdes williamdes changed the title Fix scaling of line width and point size in gis visualization Fix #17033 - scaling of line width and point size in gis visualization Jul 29, 2021
@williamdes
Copy link
Member

It works great !
All the code runs fine, I used Chrome coverage to be sure I missed no line in my testing

@williamdes williamdes merged commit 850de8a into phpmyadmin:QA_5_1 Jul 29, 2021
pull-requests automation moved this from Reviewer approved to Done Jul 29, 2021
@williamdes williamdes added this to the 5.1.2 milestone Jul 29, 2021
@williamdes williamdes self-assigned this Jul 29, 2021
@williamdes williamdes added the ui Issues relating to the user interface label Jul 29, 2021
@MoonE MoonE deleted the fix-gis-line-point-scale branch August 1, 2021 00:26
MauricioFauth added a commit to MauricioFauth/phpmyadmin that referenced this pull request Apr 24, 2022
Removed by phpmyadmin#17041.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
MauricioFauth added a commit to MauricioFauth/phpmyadmin that referenced this pull request Apr 24, 2022
Removed by phpmyadmin#17041.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Issues relating to the user interface
Projects
pull-requests
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants