-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Add Index dialog with modal #17125
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17125 +/- ##
============================================
- Coverage 49.12% 47.83% -1.30%
- Complexity 16658 16671 +13
============================================
Files 602 575 -27
Lines 59797 60491 +694
============================================
- Hits 29378 28935 -443
- Misses 30419 31556 +1137
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
f9cf5e7
to
bd0059a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is not working for me. The modal is not showing up.
bd0059a
to
c5a04f3
Compare
Can you check now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test suite are failing.
https://github.com/phpmyadmin/phpmyadmin/runs/3777540804?check_suite_focus=true#step:10:138
Signed-off-by: Saksham Gupta <shucontech@gmail.com> Index type selection box Signed-off-by: Saksham Gupta <shucontech@gmail.com> Fix open bugs Signed-off-by: Saksham Gupta <shucontech@gmail.com>
c5a04f3
to
dc82305
Compare
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Saksham Gupta shucontech@gmail.com
Description
Before submitting pull request, please review the following checklist:
Signed-off-by
line as described in our DCO. This ensures that the work you're submitting is your own creation.