Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Add Index dialog with modal #17125

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

shucontech
Copy link
Contributor

Signed-off-by: Saksham Gupta shucontech@gmail.com

Description

Before submitting pull request, please review the following checklist:

  • Make sure you have read our CONTRIBUTING.md document.
  • Make sure you are making a pull request against the correct branch. For example, for bug fixes in a released version use the corresponding QA branch and for new features use the master branch. If you have a doubt, you can ask as a comment in the bug report or on the mailing list.
  • Every commit has proper Signed-off-by line as described in our DCO. This ensures that the work you're submitting is your own creation.
  • Every commit has a descriptive commit message.
  • Every commit is needed on its own, if you have just minor fixes to previous commits, you can squash them.
  • Any new functionality is covered by tests.

@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #17125 (bd0059a) into master (b4a8a1b) will decrease coverage by 1.29%.
The diff coverage is n/a.

❗ Current head bd0059a differs from pull request most recent head b21c92e. Consider uploading reports for the commit b21c92e to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master   #17125      +/-   ##
============================================
- Coverage     49.12%   47.83%   -1.30%     
- Complexity    16658    16671      +13     
============================================
  Files           602      575      -27     
  Lines         59797    60491     +694     
============================================
- Hits          29378    28935     -443     
- Misses        30419    31556    +1137     
Flag Coverage Δ
dbase-extension 47.58% <ø> (-0.65%) ⬇️
recode-extension 47.56% <ø> (-0.09%) ⬇️
unit-7.2-ubuntu-latest 47.56% <ø> (-0.09%) ⬇️
unit-7.3-ubuntu-latest 50.58% <ø> (+0.33%) ⬆️
unit-7.4-ubuntu-latest 50.60% <ø> (-0.95%) ⬇️
unit-8.0-ubuntu-latest 50.64% <ø> (+0.29%) ⬆️
unit-8.1-ubuntu-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/classes/Controllers/CheckRelationsController.php 0.00% <0.00%> (-82.61%) ⬇️
...lasses/Controllers/Server/PrivilegesController.php 0.00% <0.00%> (-44.59%) ⬇️
...classes/Controllers/Table/OperationsController.php 0.00% <0.00%> (-43.23%) ⬇️
...es/classes/Controllers/Export/ExportController.php 0.00% <0.00%> (-41.98%) ⬇️
libraries/classes/Sql.php 12.28% <0.00%> (-35.27%) ⬇️
libraries/classes/Bookmark.php 28.57% <0.00%> (-16.72%) ⬇️
libraries/classes/Transformations.php 47.97% <0.00%> (-13.45%) ⬇️
libraries/classes/Url.php 52.94% <0.00%> (-11.51%) ⬇️
libraries/classes/StorageEngine.php 63.68% <0.00%> (-5.98%) ⬇️
...ries/classes/Plugins/Auth/AuthenticationConfig.php 70.14% <0.00%> (-5.98%) ⬇️
... and 313 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4a8a1b...b21c92e. Read the comment docs.

Copy link
Member

@MauricioFauth MauricioFauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is not working for me. The modal is not showing up.

@shucontech
Copy link
Contributor Author

This pull request is not working for me. The modal is not showing up.

Can you check now?

Copy link
Member

@MauricioFauth MauricioFauth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

Index type selection box

Signed-off-by: Saksham Gupta <shucontech@gmail.com>

Fix open bugs

Signed-off-by: Saksham Gupta <shucontech@gmail.com>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth merged commit 4a606ee into phpmyadmin:master Jan 31, 2022
@MauricioFauth MauricioFauth self-assigned this Jan 31, 2022
@williamdes williamdes added this to the 5.3.0 milestone Feb 1, 2022
@williamdes williamdes added the ui Issues relating to the user interface label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Issues relating to the user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants