A collection of small code refactorings

[kamil-tekiela]

These are unrelated changes that were identified using automatic tools such as phpStorm or SonarLint.

[codecov]

Codecov Report

Merging #17269 (73b7094) into master (3acaca5) will increase coverage by 0.01%.
The diff coverage is 36.11%.

@@             Coverage Diff              @@
##             master   #17269      +/-   ##
============================================
+ Coverage     48.82%   48.83%   +0.01%     
+ Complexity    16640    16636       -4     
============================================
  Files           601      601              
  Lines         59828    59810      -18     
============================================
- Hits          29213    29211       -2     
+ Misses        30615    30599      -16     

Flag	Coverage Δ
dbase-extension	48.58% <36.11%> (-0.02%)	⬇️
recode-extension	48.55% <36.11%> (-0.01%)	⬇️
unit-7.2-ubuntu-latest	47.38% <36.11%> (-0.07%)	⬇️
unit-7.3-ubuntu-latest	50.15% <37.14%> (+0.02%)	⬆️
unit-7.4-ubuntu-latest	50.14% <37.14%> (-0.07%)	⬇️
unit-8.0-ubuntu-latest	50.21% <37.14%> (-0.09%)	⬇️
unit-8.1-ubuntu-latest	50.35% <37.14%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/classes/Controllers/Export/ExportController.php	41.97% <0.00%> (+0.28%)	⬆️
...classes/Controllers/Table/OperationsController.php	43.22% <0.00%> (+0.31%)	⬆️
...ries/classes/Controllers/View/CreateController.php	0.00% <0.00%> (ø)
libraries/classes/InsertEdit.php	86.69% <ø> (ø)
libraries/classes/Display/Results.php	60.66% <30.43%> (+0.19%)	⬆️
libraries/classes/DatabaseInterface.php	24.61% <50.00%> (+0.06%)	⬆️
libraries/classes/Setup/Index.php	38.20% <100.00%> (ø)
libraries/classes/Table/Search.php	79.45% <100.00%> (ø)
libraries/classes/Partitioning/Partition.php	17.20% <0.00%> (-8.61%)	⬇️
libraries/classes/Template.php	79.16% <0.00%> (-6.25%)	⬇️
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3acaca5...73b7094. Read the comment docs.

[williamdes]

💯