Fix unexpected behaviour of Processlist filter #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deven Bansod <devenbansod.bits@gmail.com>
|
Looks good. Thanks |
madhuracj
added a commit
that referenced
this pull request
Jul 22, 2015
Fix unexpected behaviour of Processlist filter
madhuracj
added a commit
that referenced
this pull request
Jul 22, 2015
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the unnecessary and problem-causing URL parameter for
showExecutingas there is already a checkbox input related to it in the form and the checked property for that is properly set, keeping in mind the submitted request parameters.Moreover, this extra url param causes a problem in the behavior that, once checked, the checkbox always remains checked as $_REQUEST['showExecuting'] was always 1.
This PR should fix the above issue.
Signed-off-by: Deven Bansod devenbansod.bits@gmail.com