Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning on non-existent table #18197

Conversation

kamil-tekiela
Copy link
Contributor

Fixes #18195

I think this bug should manifest itself in a lot more places. The codebase is not very strict when it comes to validating input data.

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
@codecov
Copy link

codecov bot commented Mar 2, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.09 ⚠️

Comparison is base (6ebbd62) 47.97% compared to head (80d7f0d) 47.88%.

Additional details and impacted files
@@             Coverage Diff              @@
##             QA_5_2   #18197      +/-   ##
============================================
- Coverage     47.97%   47.88%   -0.09%     
- Complexity    16928    16975      +47     
============================================
  Files           607      607              
  Lines         62402    72308    +9906     
============================================
+ Hits          29935    34623    +4688     
- Misses        32467    37685    +5218     
Flag Coverage Δ
dbase-extension 47.34% <50.00%> (-0.59%) ⬇️
recode-extension 48.49% <50.00%> (+1.17%) ⬆️
unit-7.2-ubuntu-latest 48.46% <50.00%> (+1.08%) ⬆️
unit-7.3-ubuntu-latest 49.09% <50.00%> (?)
unit-7.4-ubuntu-latest 47.78% <50.00%> (?)
unit-8.0-ubuntu-latest 49.19% <50.00%> (?)
unit-8.1-ubuntu-latest 48.64% <50.00%> (?)
unit-8.2-ubuntu-latest 48.64% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libraries/classes/Plugins/Export/ExportXml.php 92.30% <50.00%> (-0.52%) ⬇️
libraries/classes/Charsets.php 73.01% <0.00%> (-12.99%) ⬇️
libraries/classes/Query/Generator.php 15.00% <0.00%> (-10.65%) ⬇️
libraries/classes/Utils/Gis.php 63.08% <0.00%> (-7.51%) ⬇️
libraries/classes/Types.php 90.15% <0.00%> (-5.93%) ⬇️
libraries/classes/WebAuthn/WebauthnLibServer.php 44.23% <0.00%> (-5.77%) ⬇️
libraries/classes/BrowseForeigners.php 56.11% <0.00%> (-5.38%) ⬇️
...ries/classes/Plugins/Auth/AuthenticationConfig.php 72.15% <0.00%> (-4.32%) ⬇️
libraries/classes/ErrorHandler.php 63.38% <0.00%> (-4.15%) ⬇️
...s/Controllers/Export/Template/UpdateController.php 42.85% <0.00%> (-3.30%) ⬇️
... and 319 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@williamdes williamdes added this to the 5.2.2 milestone Mar 2, 2023
@MauricioFauth MauricioFauth merged commit 29c7705 into phpmyadmin:QA_5_2 Mar 8, 2023
@MauricioFauth MauricioFauth self-assigned this Mar 8, 2023
@kamil-tekiela kamil-tekiela deleted the Fix-warning-on-non-existent-table branch March 8, 2023 19:53
williamdes added a commit that referenced this pull request Mar 10, 2023
Ref: b3c35c2
Ref: 80d7f0d
Pull-request: #18197
Pull-request: #18200
Pull-request: #18208
Pull-request: #18220

Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants