Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when changing password #18220

Merged
merged 1 commit into from Mar 8, 2023

Conversation

liviuconcioiu
Copy link
Contributor

@liviuconcioiu liviuconcioiu commented Mar 5, 2023

Description

This PR fixes an error introduced by #18208

Ref: #18093

Uncaught TypeError: can't access property "value", passwordForm.elements.username is undefined when changing password from home page.

Before:

05.03.2023_18.39.40_REC.mp4

After:

05.03.2023_18.57.28_REC.mp4

Another way to solve this is to move this line, one line up.

<input type="hidden" name="username" value="{{ username }}">

Signed-off-by: Liviu-Mihail Concioiu <liviu.concioiu@gmail.com>
@codecov
Copy link

codecov bot commented Mar 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (bf1b0a2) 47.85% compared to head (1d6dada) 47.87%.

Additional details and impacted files
@@             Coverage Diff              @@
##             QA_5_2   #18220      +/-   ##
============================================
+ Coverage     47.85%   47.87%   +0.02%     
+ Complexity    16974    16973       -1     
============================================
  Files           607      607              
  Lines         72306    72306              
============================================
+ Hits          34602    34618      +16     
+ Misses        37704    37688      -16     
Flag Coverage Δ
dbase-extension 47.41% <100.00%> (-0.47%) ⬇️
recode-extension 47.29% <100.00%> (-0.04%) ⬇️
unit-7.2-ubuntu-latest 48.52% <100.00%> (+1.16%) ⬆️
unit-7.3-ubuntu-latest 47.77% <100.00%> (-1.36%) ⬇️
unit-7.4-ubuntu-latest 49.08% <100.00%> (+1.29%) ⬆️
unit-8.0-ubuntu-latest 47.85% <100.00%> (+<0.01%) ⬆️
unit-8.1-ubuntu-latest 47.85% <100.00%> (-0.01%) ⬇️
unit-8.2-ubuntu-latest 49.13% <100.00%> (+1.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libraries/classes/Git.php 67.42% <100.00%> (ø)
libraries/classes/Transformations.php 62.03% <0.00%> (-1.86%) ⬇️
libraries/classes/Header.php 88.37% <0.00%> (+0.99%) ⬆️
libraries/classes/Charsets.php 73.01% <0.00%> (+26.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@williamdes williamdes added this to the 5.2.2 milestone Mar 5, 2023
@MauricioFauth MauricioFauth merged commit 15a9de5 into phpmyadmin:QA_5_2 Mar 8, 2023
@MauricioFauth MauricioFauth self-assigned this Mar 8, 2023
@liviuconcioiu liviuconcioiu deleted the 18093_1 branch March 8, 2023 13:28
williamdes added a commit that referenced this pull request Mar 10, 2023
Ref: b3c35c2
Ref: 80d7f0d
Pull-request: #18197
Pull-request: #18200
Pull-request: #18208
Pull-request: #18220

Signed-off-by: William Desportes <williamdes@wdes.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants