Add support for statement messages in FlashMessenger class #19169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
This class handles the flash messages instead of being a collection of flash messages, so FlashMessenger is a better name. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
src/FlashMessenger.php
Outdated
|
|
||
| /** @var mixed[] */ | ||
| private array $storage; | ||
|
|
||
| /** @var array<string, string[]> */ | ||
| /** @psalm-var list<array{context: string, message: string, statement: string}> */ |
There was a problem hiding this comment.
I don't think there's anything Psalm-specific here anymore. Both list and array shape are universally supported.
There was a problem hiding this comment.
I think sudo-bot/action-doctum does not support this format yet. Am I right, @williamdes?
src/Twig/MessageExtension.php
Outdated
| /** @inheritDoc */ | ||
| public function getFunctions(): array | ||
| { | ||
| return [new TwigFunction('statement_message', Generator::getMessage(...), ['is_safe' => ['html']])]; |
There was a problem hiding this comment.
That match statement would fit here more than inside the function. You can do an anonymous function and as a default throw an exception so that we avoid typos.
There was a problem hiding this comment.
I will left MessageType::Notice as default for now, as I think Generator::getMessage() should be refactored to extract all the HTML from it, and maybe a view helper for MessageType to match with the Bootstrap classes.
Does not group the messages by context. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
MauricioFauth
force-pushed
the
flash-messages-statement
branch
from
90514b9
to
d17e46c
Compare
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides standard feedback messages, is also common to have a feedback message with the executed statement after an action is executed. This allows to use HTTP redirection in those cases.