Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GIS editor modal #19182

Merged
merged 4 commits into from
May 31, 2024
Merged

Conversation

MauricioFauth
Copy link
Member

Extracts OpenLayers JS from the GIS PHP classes.

@MauricioFauth MauricioFauth force-pushed the gis-editor branch 2 times, most recently from 5fdd66d to b90de78 Compare May 31, 2024 07:24
@MauricioFauth MauricioFauth marked this pull request as ready for review May 31, 2024 07:25
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@MauricioFauth MauricioFauth self-assigned this May 31, 2024
@MauricioFauth MauricioFauth merged commit 026e8f2 into phpmyadmin:master May 31, 2024
44 of 45 checks passed
@MauricioFauth MauricioFauth deleted the gis-editor branch May 31, 2024 18:27
@MauricioFauth MauricioFauth added this to the 6.0.0 milestone May 31, 2024
@MoonE
Copy link
Contributor

MoonE commented Jun 1, 2024

Thanks you for the updated layout of the gis editor. It looks a lot better.

I found some bugs resulting from these changes:

  • labels are missing in the OpenLayers visualization
  • the Start row and number of rows inputs no longer work in the OpenLayers visualization
  • in the editor the textarea should not be resizable horizontally
  • in the editor when selecting gemetrycollection as type the visualization still shows the last geometry, but should be empty, as the default is an empty geometry collection

The editor modal should not be closable by clicking outside of it. All the form input data will be lost in this case. It's just too easy to accidentally close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants