refactor server_import and related files

[xmujay]

No description provided.

[xmujay]

Hi Marc,
this pull request is about the refactor about import page for server, table, database. I have tested fully.

changes:

1. rename display_import.lib.php to display_import.inc.php
2. split long code to functions
3. move function to display_import.lib.php
4. fix the included file: table, database, server
5. render html at once
6. split long js

thanks for your review

[xmujay]

here is to fix undefined error of $sql_data['valid_queries'] after imported

[lem9]

Bin,
when trying a table import, I don't see the table name in the top portion. Instead I see a big number like 31.

[xmujay]

thanks Marc, I am fixing the issues now. thanks

[lem9]

Hi Bin,
you mention "fully tested". Which upload progress mechanisms have you tested (progress, apc)?

[xmujay]

Hi Marc, I just test from my side on database, table, server levels import. the import process is working well and not error output.

but I have no idea about the apc testing..

[lem9]

Bin,
have a look at http://docs.phpmyadmin.net/en/latest/faq.html#faq2-9

[xmujay]

thanks, it is useful. I will test upload bar branch now.

BTW, the table name issues have been fixed.

[xmujay]

still have some upload bar issue. close it. will reopen when fixed. thanks

[xmujay]

Hi Marc,

for the js part, If I split to a separated file, the js file can't use the PHP variable. so now I add a new function to render javascript out : PMA_getHtmlForImportNoPlugin

for this part of js code, I will refactor more if I have idea to split js to a separated file. thanks

[xmujay]

I have tested both upload on progress and apc.

the status bar can working well.

but the process is so quick, so if you want to see the bar, you can set "if (finished == true)" to "if (false)"
or upload a large file. thanks
https://github.com/phpmyadmin/phpmyadmin/pull/542/files#L3R553

[xmujay]

the side bar should be reloaded when import finished

[lem9]

Hi Bin,
did you intentionally close this pull request?

[xmujay]

Hi Marc,

Yes.
I close this pull request because there is a remaining issue should be fixed.

I have no idea how to put this line about reload the navigation panel when import finished.
https://github.com/phpmyadmin/phpmyadmin/pull/542/files#L3L140

I will discuss with other developers on mail list and make more investigations.

I will reopen the pull request when fixing this issue.

BTW, other features are all working well. thanks

[lem9]

Hi Bin,
please be careful because a bug fix was merged today, see 80e6ecc

[xmujay]

thanks Marc,

I have fixed all the issues about this pull request.

and I tested both on process and apc upload for database, server, table import.

thanks for your review.

[xmujay]

here is to reload the navigation panel when import finished on JS level.

thanks Marc's advice

[lem9]

Good job!