Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug 4110 #723

Closed
wants to merge 2 commits into from
Closed

fix bug 4110 #723

wants to merge 2 commits into from

Conversation

xmujay
Copy link
Contributor

@xmujay xmujay commented Sep 29, 2013

No description provided.

@xmujay
Copy link
Contributor Author

xmujay commented Sep 29, 2013

Hi Marc,
this pull request is to fix bug 4110
http://sourceforge.net/p/phpmyadmin/bugs/4110/

the root cause is that the function of PMA_getHtmlForDatabaseList will change the value of $column_order. so I add a reference to it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) when pulling ef2535c on xmujay:bug_4110 into d2210b0 on phpmyadmin:master.

@ghost ghost assigned lem9 Sep 29, 2013
@lem9
Copy link

lem9 commented Sep 29, 2013

Hi Bin,
you correctly found the cause but I suggest a better fix. With your fix, the problem is that, at the calling point for the function, we don't see that $column_order is affected. Please have the function return an array instead. This is the same principle than PMA_buildHtmlForDb() is doing.

There will be also a test to adjust. Closing for now; please create another branch with the suggested fix.

@lem9 lem9 closed this Sep 29, 2013
rakeshkumar4294 added a commit to rakeshkumar4294/phpmyadmin that referenced this pull request Feb 8, 2015
@rakeshkumar4294
Feature-request phpmyadmin#723
d15fc1d 
Signed-off-by: RAKESH KUMAR <rakeshkumar4294@gmail.com>
rakeshkumar4294 added a commit to rakeshkumar4294/phpmyadmin that referenced this pull request Feb 8, 2015
@rakeshkumar4294
Feature-request phpmyadmin#723
4e3563d 
Signed-off-by: RAKESH KUMAR <rakeshkumar4294@gmail.com>
rakeshkumar4294 added a commit to rakeshkumar4294/phpmyadmin that referenced this pull request Feb 8, 2015
@rakeshkumar4294
Feature-request phpmyadmin#723
eb29061 
Signed-off-by: RAKESH KUMAR <rakeshkumar4294@gmail.com>
rakeshkumar4294 added a commit to rakeshkumar4294/phpmyadmin that referenced this pull request Feb 8, 2015
@rakeshkumar4294
Revert "Feature-request phpmyadmin#723"
bdeb0c1 
This reverts commit eb29061.
rakeshkumar4294 added a commit to rakeshkumar4294/phpmyadmin that referenced this pull request Feb 8, 2015
@rakeshkumar4294
Revert "Feature-request phpmyadmin#723"
8a0fe03 
This reverts commit eb29061.
rakeshkumar4294 added a commit to rakeshkumar4294/phpmyadmin that referenced this pull request Feb 8, 2015
@rakeshkumar4294
Feature Request phpmyadmin#723
7e3fb94 
Signed-off-by: RAKESH KUMAR <rakeshkumar4294@gmail.com>
rakeshkumar4294 added a commit to rakeshkumar4294/phpmyadmin that referenced this pull request Feb 8, 2015
@rakeshkumar4294
Feature request phpmyadmin#723
cf2f80a 
Signed-off-by: RAKESH KUMAR <rakeshkumar4294@gmail.com>
lem9 pushed a commit that referenced this pull request Feb 10, 2015
Merge pull request #1491 from rakeshkaundilya/rfe#723
9ab5f1f 
Sanity Check for table name : Feature request #723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lem9 lem9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmujay @coveralls @lem9