This repository has been archived by the owner. It is now read-only.

Use PSR-1 for PHPUnit TestCase #1

Merged
merged 1 commit into from Nov 8, 2017

Conversation

Projects
None yet
2 participants
@carusogabriel
Contributor

carusogabriel commented Nov 6, 2017

Use PSR-1 while extending PHPUnit TestCase class. This will help us when to migrate to PHPUnit 6, that no longer support snake case namespaces.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 6, 2017

Codecov Report

Merging #1 into master will decrease coverage by 0.39%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #1     +/-   ##
===========================================
- Coverage     98.38%   97.98%   -0.4%     
- Complexity        0       90     +90     
===========================================
  Files            22       22             
  Lines           186      199     +13     
===========================================
+ Hits            183      195     +12     
- Misses            3        4      +1

codecov bot commented Nov 6, 2017

Codecov Report

Merging #1 into master will decrease coverage by 0.39%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #1     +/-   ##
===========================================
- Coverage     98.38%   97.98%   -0.4%     
- Complexity        0       90     +90     
===========================================
  Files            22       22             
  Lines           186      199     +13     
===========================================
+ Hits            183      195     +12     
- Misses            3        4      +1

@nijel nijel merged commit 5dde3e4 into phpmyadmin:master Nov 8, 2017

4 of 5 checks passed

codecov/project 97.98% (-0.4%) compared to 6ae2749
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing 6ae2749...7bcdf7a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nijel nijel self-assigned this Nov 8, 2017

@carusogabriel carusogabriel deleted the carusogabriel:phpunit branch Nov 8, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.