Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"ALTER EVENT" is not recognized by the SQL parser #404

Closed
SanaRebhi opened this issue Jan 4, 2023 · 2 comments · Fixed by #408
Closed

"ALTER EVENT" is not recognized by the SQL parser #404

SanaRebhi opened this issue Jan 4, 2023 · 2 comments · Fixed by #408
Assignees
@williamdes
Labels
bug enhancement
Milestone
5.7.0

Comments

@SanaRebhi
Copy link

SanaRebhi commented Jan 4, 2023 •
edited

It seems that the latest release of sql-parser (5.6.0) does not support "ALTER EVENTS" yet.
The AlterOperation component needs to be updated in order to add all the options for the EVENT.
Any plans to handle this kind of statements please?
@williamdes
Copy link
Member

Sure, thanks for reporting this :)

@iifawzi if you want to contribute :p

@iifawzi
Copy link
Contributor

iifawzi commented Jan 6, 2023

Sure, thanks for reporting this :)

@iifawzi if you want to contribute :p

Sure, most probably by the end of the next week, I will get back on the track

niconoe- added a commit to niconoe-/sql-parser that referenced this issue Jan 9, 2023
@niconoe-
Try to fix phpmyadmin#404. Miss some unit tests.
872e5bb
This was referenced Jan 9, 2023
Merged
Merged
williamdes added a commit that referenced this issue Jan 12, 2023
@williamdes
Merge #409 - Ref #404 - Add ALTER EVENT tests and keywords without pa…
9306568 
…rser implementation

Pull-request: #409

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jan 12, 2023
@williamdes
Merge #408 - Fix #404 - Implement ALTER EVENT
81c583a 
Fixes: #404
Pull-request: #408

Signed-off-by: William Desportes <williamdes@wdes.fr>
williamdes added a commit that referenced this issue Jan 12, 2023
@williamdes
Add a CHANGELOG entry for #404
b86a801 
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes self-assigned this Jan 12, 2023
@williamdes williamdes added this to the 5.7.0 milestone Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamdes williamdes

Labels
bug enhancement
Projects
None yet
Milestone
5.7.0
Development

Successfully merging a pull request may close this issue.

Fix #404 - Implement ALTER EVENT niconoe-/sql-parser
3 participants
@williamdes @iifawzi @SanaRebhi