Skip to content

Ref #404 - Add ALTER EVENT tests and keywords without parser implementation #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2023
Merged

Ref #404 - Add ALTER EVENT tests and keywords without parser implementation #409

merged 1 commit into from
Jan 12, 2023

Conversation

niconoe-
Copy link
Contributor

@niconoe- niconoe- commented Jan 12, 2023 •
edited by williamdes
Loading

Ref: #404

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Base: 97.25% // Head: 97.25% // No change to project coverage 👍

Coverage data is based on head (fb1dac3) compared to base (c8a83aa).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #409   +/-   ##
=========================================
  Coverage     97.25%   97.25%           
  Complexity     2192     2192           
=========================================
  Files            68       68           
  Lines          5055     5055           
=========================================
  Hits           4916     4916           
  Misses          139      139

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@niconoe- niconoe- mentioned this pull request Jan 12, 2023
Merged
@williamdes williamdes self-assigned this Jan 12, 2023
@williamdes williamdes added this to the 5.7.0 milestone Jan 12, 2023
williamdes
williamdes approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@williamdes williamdes changed the title Add ALTER EVENT tests and keywords without implementing the reading of such statements by the parser. Add ALTER EVENT tests and keywords without parser implementation Jan 12, 2023
@williamdes williamdes changed the title Add ALTER EVENT tests and keywords without parser implementation Ref #404 - Add ALTER EVENT tests and keywords without parser implementation Jan 12, 2023
@williamdes williamdes merged commit 9306568 into phpmyadmin:master Jan 12, 2023
@niconoe- niconoe- deleted the before-404-fix branch January 12, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamdes williamdes williamdes approved these changes

Assignees

@williamdes williamdes

Labels
None yet
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@niconoe- @williamdes