ALTER TABLE … RENAME COLUMN … TO … not understood by the parser/linter

[niconoe-]

When trying to parse the following SQL statement, the AlterStatement createed regarding this SQL is missing the "TO" option and the new name of the column.

ALTER TABLE potato RENAME COLUMN `KIND` TO `VARIETY`;

The linter give also the error:

> bin/lint-query --query 'ALTER TABLE potato RENAME COLUMN `KIND` TO `VARIETY`;'
#1: Virgule manquante avant le début d’une nouvelle opération ALTER. (near "TO" at position 40)

(French translation for "#1: Missing comma before the beginning of a new ALTER operation.").

[niconoe-]

After a little analysis, this is because the AlterOperation is expected to be templated like this:
[...OPTIONS] <field> [...UNKNOWN]

But this is not true for every ALTER operation, even when staying in the context of a table. Or we can make it true, but that means the [...UNKNOWN] part is never interpreted correctly, as it just contains a list of tokens without any useful information.

I was about to provide a PR so that only for RENAME COLUMN operation, we parse again the options to get the TO and to merge it, as to me, the AlterOperation would be cleaner this way, but this breaks how the Builder is behaving. I could also add a specific case for the RENAME COLUMN in the builder, but it looks like putting a tape on a hole rather than really parsing the alter operations correctly.

Anyway, I'll provide my PR and if you can find a cleaner way to manage this situation, I'll be your man 😆