Fix #430 - ALTER TABLE … RENAME COLUMN … TO … is not understood by the parser/linter

[niconoe-]

Fixes #430

I agree that this PR adds a specific management case for the RENAME COLUMN. If you find this too specific, you could try to give me hints on how to do this in a cleaner way, as I'm unsure this could be possible.

Thanks.

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (1ac927f) 97.04% compared to head (284ba3a) 97.07%.

❗ Current head 284ba3a differs from pull request most recent head 8b30047. Consider uploading reports for the commit 8b30047 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##              5.8.x     #432      +/-   ##
============================================
+ Coverage     97.04%   97.07%   +0.03%     
+ Complexity     2209     2182      -27     
============================================
  Files            69       69              
  Lines          5083     4999      -84     
============================================
- Hits           4933     4853      -80     
+ Misses          150      146       -4     

Impacted Files	Coverage Δ
src/Components/AlterOperation.php	100.00% <100.00%> (ø)

... and 50 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[niconoe-]

Failing checks are only due to unmodified files. I don't expect to fix them on this PR.

[williamdes]

Looks good !
Out of curiosity, what happens to a query that renames two columns and also renames an index ?
Is it possible ?
https://dev.mysql.com/doc/refman/8.0/en/alter-table.html

[niconoe-]

Looks good ! Out of curiosity, what happens to a query that renames two columns and also renames an index ? Is it possible ? https://dev.mysql.com/doc/refman/8.0/en/alter-table.html

This worth a unit test to check 😆

On MySQL, it is possible and it works fine. But I don't know how the parser manages it.

[niconoe-]

Unit tests added via a provider to easily add some more.

And after some tests, it appears that there was just an extra space in the builder but after a trim, everything works fine ;)

[williamdes]

Ah, the base is not the right one. Can you rebase onto 5.8.x ?
Git is not happy with that, so manually you need to hard set onto 5.8.x and cherry-pick each commit and then git push --force when you are finished

[niconoe-]

I wasn't able to hard set onto 5.8.x so I create a new PR (#433) from a branch that starts from 5.8.x and cherry-picks my (fixed-up) commits.

You can close this PR now, if #433 is OK for you.

[williamdes]

I wasn't able to hard set onto 5.8.x so I create a new PR (#433) from a branch that starts from 5.8.x and cherry-picks my (fixed-up) commits.

You can close this PR now, if #433 is OK for you.

Well, let's keep this one ;)
What I did is reset hard to your other branch, and force push this one to it

[williamdes]

All green ✅