Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to configure the visibility in the PropertyAssembler #50

Closed
veewee opened this issue Jun 30, 2017 · 1 comment
Closed

Comments

@veewee
Copy link
Contributor

veewee commented Jun 30, 2017

Currently the PropertyAssembler generates protected properties by default.
Since we mostly don't extend these types, it is a better idea to change the default to private.

    /**
     * @var string
     */
    protected $someFilter;

This could be done by adding the visibility as a constructor parameter to the PropertyAssembler and changing the defaults in the Configuration file. This way you can still choose to use protected or even public if you're a real daredevil.

@veewee
Copy link
Contributor Author

veewee commented Jun 30, 2017

Fixed in #53

@veewee veewee closed this as completed Jun 30, 2017
@veewee veewee added this to the 0.4.1 milestone Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant