min/max functions cannot resolve final value range if one of values is variable or constant

[lulco]

Bug report

min/max functions cannot resolve final value range if one of values is variable or constant

Code snippet that reproduces the problem

https://phpstan.org/r/2a2c7b0c-c410-40ff-b2a5-d6c8036f3780

Expected output

Expected output in these cases is that return value is positive integer. So no error will be reported.

[ondrejmirtes]

Needs to be adjusted in https://github.com/phpstan/phpstan-src/blob/master/src/Type/Php/MinMaxFunctionReturnTypeExtension.php.

[phpstan-bot]

@lulco After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 20: Dumped type: int
-21: Method HelloWorld::incorrect() should return int<1, max> but returns int.
-29: Dumped type: int
-30: Method HelloWorld::incorrectWithConstant() should return int<1, max> but returns int.
+29: Dumped type: int

Full report

Line	Error
20	Dumped type: int
29	Dumped type: int

[ondrejmirtes]

Implemented: phpstan/phpstan-src@458f5d2

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.