Refinement of key existence is wrong when using a AND in a condition

[stof]

Bug report

When using if (!isset($a['first_key']) && !isset($a['second_key'])) return;, phpstan refines first_key as not being optional in the array shape of $a after the early return

Code snippet that reproduces the problem

https://phpstan.org/r/292eadfe-27e6-4668-b7e5-ccc91c581290

Expected output

The array_key_exists call is not reported as useless by strict rules, because team_name can indeed be missing when reaching it.

Did PHPStan help you today? Did it make you happy in any way?

[ondrejmirtes]

/cc @rajyan Sounds like something for you :)

[rajyan]

The problem is explained here phpstan/phpstan-src#1307 (comment)

The isset reverNonNullability process is not working for optional keys now, so simply calling a no effect isset call can causes the same issue.
https://phpstan.org/r/38eec6d5-b006-454f-831f-17ae030321d5

[phpstan-bot]

@stof After the latest push in 1.8.x, PHPStan now reports different result with your code snippet:

@@ @@
  7: Dumped type: array{id: string, name?: string, team_name?: string|null}
-12: Dumped type: array{id: string, name?: string, team_name: string|null}
-16: Call to function array_key_exists() with 'team_name' and array{id: string, name?: string, team_name: string|null} will always evaluate to true.
+12: Dumped type: array{id: string, name?: string, team_name?: string|null}

Full report

Line	Error
7	`Dumped type: array{id: string, name?: string, team_name?: string
12	`Dumped type: array{id: string, name?: string, team_name?: string

[phpstan-bot]

@rajyan After the latest push in 1.8.x, PHPStan now reports different result with your code snippet:

@@ @@
  7: Dumped type: array{id: string, name?: string, team_name?: string|null}
-12: Dumped type: array{id: string, name?: string, team_name: string|null}
-16: Call to function array_key_exists() with 'team_name' and array{id: string, name?: string, team_name: string|null} will always evaluate to true.
+12: Dumped type: array{id: string, name?: string, team_name?: string|null}

Full report

Line	Error
7	`Dumped type: array{id: string, name?: string, team_name?: string
12	`Dumped type: array{id: string, name?: string, team_name?: string

[ondrejmirtes]

@rajyan This is how I fixed revertNonNullability :) phpstan/phpstan-src@0654852?w=1

The issue was that Scope::specifyExpressionType also changed ArrayDimFetch::$var type without having EnsuredNonNullabilityResult know about it. So I discovered this changed expression by comparing the type against $originalScope, and added another EnsuredNonNullabilityResult with that so that it knows it has to be reverted.

[rajyan]

@ondrejmirtes
Thank you very much for the fix! Looks good to me 👍

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.