Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable/unusable builds since 3.29.36 #103

Closed
stesie opened this issue Sep 16, 2014 · 4 comments
Closed

Unstable/unusable builds since 3.29.36 #103

stesie opened this issue Sep 16, 2014 · 4 comments

Comments

@stesie
Copy link
Member

stesie commented Sep 16, 2014

We need to call v8::V8::InitializePlatform on startup now and v8::V8::ShutdownPlatform on shutdown.

See http://comments.gmane.org/gmane.comp.lang.javascript.v8.general/8029

@stesie
Copy link
Member Author

stesie commented Sep 16, 2014

I've prepared a fix at https://github.com/stesie/v8js/tree/fix-init-platform
Maybe someone is willing to give it a try with a recent v8 version.

V8 now ships with a small library named libplatform, which we can use to provide a platform implementation to V8 (instead of providing our own)

@rosmo
Copy link

rosmo commented Sep 17, 2014

Could you build that branch on Jenkins? It would probably provide the best feedback if this still work.

@stesie
Copy link
Member Author

stesie commented Sep 17, 2014

Sure I can, and I'm actually on it. However I first have to rebuild the latest v8 library versions and keep the libplatform stuff as well.

Apart from that, I actually wanted to signalize that I'm working on the topic and wanted to collect some feedback whether using libplatform is the way to go for us. It's complicating the build process a little bit, but should still be ok ...

@stesie
Copy link
Member Author

stesie commented Sep 17, 2014

Ok, Jenkins finished his work ... everything's building fine, hence I'll go and merge ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants