-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unstable/unusable builds since 3.29.36 #103
Comments
I've prepared a fix at https://github.com/stesie/v8js/tree/fix-init-platform V8 now ships with a small library named libplatform, which we can use to provide a platform implementation to V8 (instead of providing our own) |
Could you build that branch on Jenkins? It would probably provide the best feedback if this still work. |
Sure I can, and I'm actually on it. However I first have to rebuild the latest v8 library versions and keep the libplatform stuff as well. Apart from that, I actually wanted to signalize that I'm working on the topic and wanted to collect some feedback whether using libplatform is the way to go for us. It's complicating the build process a little bit, but should still be ok ... |
Ok, Jenkins finished his work ... everything's building fine, hence I'll go and merge ... |
We need to call
v8::V8::InitializePlatform
on startup now andv8::V8::ShutdownPlatform
on shutdown.See http://comments.gmane.org/gmane.comp.lang.javascript.v8.general/8029
The text was updated successfully, but these errors were encountered: