Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for old v8 versions #104

Closed
stesie opened this issue Sep 17, 2014 · 2 comments
Closed

Support for old v8 versions #104

stesie opened this issue Sep 17, 2014 · 2 comments

Comments

@stesie
Copy link
Member

stesie commented Sep 17, 2014

Currently we require v8 version 3.22.3 or newer, however older ones aren't actively maintained by Google. I think it's a bit intransparent which versions are actively maintained, according to https://code.google.com/p/v8/wiki/Source usually the last two branches.
According to http://omahaproxy.appspot.com/ currently stable Google Chrome browser uses v8 version 3.27.34.17

So almost certainly there's no maintenance for 3.26.x and earlier and we currently have a whole lot of preprocessing macros to achieve compatibility with those rather old versions. Especially the V8JS_NEW, V8JS_INT, V8JS_UINT and V8JS_DATE ones are really ugly ... and could be dropped, if we require 3.27.0 or newer ..

I don't see any reason why to support older versions and would step up and remove that glue stuff.
Any objections? @preillyme @rosmo @cscott

(and after all, someone who needs a older v8 version could pick a slightly older v8js, i.e. current master)

@rosmo
Copy link

rosmo commented Sep 17, 2014

Fine with me!

@stesie
Copy link
Member Author

stesie commented Sep 17, 2014

Besides 3.25.25 to 3.26.12 aren't stable, the PHP fatal error unwinding doesn't work correctly with these.

@stesie stesie closed this as completed in 51930e7 Oct 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants