Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RRDataContainer.get_df doesn't do anything #10

Closed
barkls opened this issue Apr 18, 2019 · 1 comment
Closed

RRDataContainer.get_df doesn't do anything #10

barkls opened this issue Apr 18, 2019 · 1 comment

Comments

@barkls
Copy link

barkls commented Apr 18, 2019

right now, calling RRDataContainer.get_df() is the same as calling RRDataContainer.dataframe.

I'm guessing that maybe you want users to call get_df() to prevent them modifying RRDataContainer.dataframe. If not, feel free to ignore the rest of this message. If you are trying to prevent modification of dataframe itself, you should rename RRDataContainer.dataframe as RRDataContainer._dataframe (attributes beginning with an underscore are not user-facing in python). You can also use a @property decorator to avoid the need for an empty open-close parentheses. See documentation for more details.

@JWatsonDaniels
Copy link
Collaborator

fixed in #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants