Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of repeated code in model.py #38

Closed
barkls opened this issue May 2, 2019 · 1 comment
Closed

Lots of repeated code in model.py #38

barkls opened this issue May 2, 2019 · 1 comment

Comments

@barkls
Copy link

barkls commented May 2, 2019

You have separate functions with and without laser skew but much of the code is duplicated between them. Either consolidate the functions into a single shared workflow or break out the duplicated code into helper functions that are called by both.

@ssghosh
Copy link
Collaborator

ssghosh commented May 10, 2019

Broke out the sampler code from Walkers and laserskew_Walkers into a helper function walkers_sampler in 97cd8c3

@ssghosh ssghosh closed this as completed May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants