Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial working vscode web extension #155

Closed
wants to merge 7 commits into from
Closed

Conversation

jamesdabbs
Copy link
Member

@jamesdabbs jamesdabbs commented Jun 3, 2024

Partially addresses #5. There are a few cascading changes here that are related, but may not look like it:

  • Getting the build system unified ran into an issue with vite v4
  • Upgrading vite to v5 implied upgrades to vitest, sveltekit
  • vitest had some breaking changes (snapshots, rejected promises)

@jamesdabbs jamesdabbs self-assigned this Jun 3, 2024
Copy link

cloudflare-pages bot commented Jun 3, 2024

Deploying topology with  Cloudflare Pages  Cloudflare Pages

Latest commit: ee22e68
Status: ✅  Deploy successful!
Preview URL: https://515b6bf8.topology.pages.dev
Branch Preview URL: https://jcd-vscode.topology.pages.dev

View logs

@jamesdabbs jamesdabbs force-pushed the jcd/vscode branch 3 times, most recently from 3f6b316 to 84c2710 Compare June 3, 2024 04:39
@jamesdabbs jamesdabbs force-pushed the jcd/vscode branch 4 times, most recently from 4c78194 to 4dbd0e9 Compare June 3, 2024 20:39
This fixes the underlying issue that required a `skipLibCheck` in the first place.
@jamesdabbs jamesdabbs force-pushed the jcd/vscode branch 3 times, most recently from 1a9c220 to fb5eb88 Compare June 4, 2024 15:21
@jamesdabbs jamesdabbs marked this pull request as ready for review June 4, 2024 15:40
@StevenClontz
Copy link
Member

Offtopic: one day I should pick your brain on your pattern of using git push -f.

@StevenClontz
Copy link
Member

I confirmed github.dev is using version 0.0.12. I'm getting this error when I click on a link:

image

@StevenClontz
Copy link
Member

StevenClontz commented Jun 4, 2024

I believe the correct file path would be /pi-base/data/properties/P000188.md

@jamesdabbs
Copy link
Member Author

jamesdabbs commented Jun 4, 2024

Offtopic: one day I should pick your brain on your pattern of using git push -f.

I like a linear history that tells a story, so will try to git commit --amend liberally to make sure that PRs contain individual, atomic commits that could be independently applied. A lot of times this happens entirely on my machine and nobody notices, but if I'm concerned about external build stuff or integration testing, I push regularly along the way (hence a lot of --force pushing). I generally limit that to PRs that are in draft, and try to make additive changes after I reasonably believe someone has reviewed the existing work.

I confirmed github.dev is using version 0.0.12. I'm getting this error when I click on a link:

Just to confirm, you're looking at https://github.dev/pi-base/data and clicking on the link that shows up in the markdown hover preview, right? (Or – if you cmd+click on the actual ID itself or use VSCode's "go to definition", are those working as expected for you?)

I believe the correct file path would be /pi-base/data/properties/P000188.md

I think it's actually some arcane vscode-vfs://github%2B<hex/pi-base/data/..., but I see what you're saying.

@jamesdabbs
Copy link
Member Author

... additive changes ...

like 113e67d

@StevenClontz
Copy link
Member

Well, the link isn't broken, but now it's not even there. 🙃

image

@jamesdabbs
Copy link
Member Author

Yeah, working on debugging it now. I have no idea why it would just silently not show up in the web, but work fine locally. It may take be a bit to get set up with some kind of process for remote debugging; I'm going to move this back to draft for now.

@jamesdabbs jamesdabbs marked this pull request as draft June 4, 2024 18:40
@jamesdabbs
Copy link
Member Author

@StevenClontz – alright 53b3c7c should fix the links in hover text. The published extension seems to be working for me on github.dev but failing to activate entirely in a dedicated codespace. 🫠 Is that also what you're seeing?

@StevenClontz
Copy link
Member

StevenClontz commented Jun 6, 2024

github.dev

Missing link at the bottom. Of course clicking the link at the top does nothing anyway - that's the same file as the item itself. Probably no need to have links here (but no big deal if it's annoying to special case this).

image

Clicking compact here successfully opens the file: 🚀

image

@StevenClontz
Copy link
Member

codespaces

For whatever reason it did not install in my browser automatically (CORS thing seems new too but I haven't looked into it):

image

one-click install:

image

Nothing at first:

image

Refresh helps:

image

Clicking $T_3$ here works:

image

image

@jamesdabbs
Copy link
Member Author

This was (squashed) merged in via #160.

@jamesdabbs jamesdabbs closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants